Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin api example update #69

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

heyOnuoha
Copy link
Collaborator

Changelog

  • restrict bitcoin example's wallet options to xDefi -- for bitcoin compatibility
  • enable two-way swaps between Ethereum and Bitcoin

FIXES DX-70

@heyOnuoha heyOnuoha requested a review from chillvybz June 21, 2024 14:05
@heyOnuoha heyOnuoha self-assigned this Jun 21, 2024
Copy link

linear bot commented Jun 21, 2024

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-directory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:38pm
examples-swaps-sdk-nextjs-web3-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:38pm
swaps-api-nextjs-bitcoin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:38pm
swaps-api-nextjs-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:38pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
gas-widget-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
staking-sdk-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
staking-widget-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
swaps-sdk-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
swaps-sdk-nextjs-thirdweb-embedded-wallet ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
swaps-widget-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm
withdraw-widget-nextjs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 5:38pm

if(error) {
toast({
variant: "destructive",
title: "Something went wrong!",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It will be awesome if we can throw a detail message.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, got it!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is quite tricky as the error message returned is a number if I remember correctly.

@heyOnuoha heyOnuoha merged commit 6c571b1 into main Jun 25, 2024
13 checks passed
@heyOnuoha heyOnuoha deleted the feat/bitcoin-api-example-update branch June 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants