Updating the way of calculate the midPoint #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveblue
reviewed
Jul 27, 2023
| let _secondX = null; | ||
| let _firstY = null; | ||
| let _secondY = null; | ||
| const dirRight = (this.layout as Layout).settings?.properties['elk.direction'] === 'RIGHT'; |
There was a problem hiding this comment.
The layout won't always be Elk, so this check needs to be more generic.
There was a problem hiding this comment.
Please also change the name of this variable to orientation and make the direction more explicit.
There was a problem hiding this comment.
Done, thanks
Please also change the name of this variable to
orientationand make the direction more explicit.
Done, thanks
steveblue
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: