Implement "print-search-dirs" argument #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly) "install" "binary" script and the search "libraries" (required by "libtool" when building shared libraries).
falhumai96
commented
Mar 7, 2022
cccl
Outdated
| # the Windows drive letter is present in the path. For instance, a path with "c:" in Wine will be converted | ||
| # to a path with "drive_c". The reason for avoiding paths with ":" is that ":" is generally unescapable in Unix | ||
| # (e.g. in "PATH" environment variable). | ||
| unix_global_library_path="$(realpath $($winpath_bin -u $libpath))" |
There was a problem hiding this comment.
I don't like to use realpath here, but it is the only way I can think of to remove the : from the Wine drives, for e.g.
I believe this argument is mostly necessary for libtool to search for libraries when creating dynamic libraries, and the issue when going to the parent folder (i.e. ../) won't happen, since only the directories in libraries will be searched.
There was a problem hiding this comment.
I resolved this issue by shortening only the Unix portion of the Windows path prefix, by parsing out the prefix using Python's pathlib's PureWindowsPath.
…r custom Python path, where the Python installation must have "pathlib" installed. Update the logic for resolving the short version of the Unix path of the Windows library directory by only shortening the prefix of the Unix version of the Windows path, using Python's "pathlib"'s "PureWindowsPath" to extract the Windows path prefix from the path. Use "winpath" to convert the Unix paths in arguments to Windows paths before sending them to Windows command arguments (e.g. in "-L" or "-I" arguments). Perform other minor code cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
print-search-dirsargument to list (currently)install"binary" script and the searchlibraries(required bylibtoolwhen building shared libraries (https://git.savannah.gnu.org/cgit/libtool.git/tree/m4/libtool.m4?id=33615a45a6926666f95da8a0dc28fc9a8c62d117#n2320)). This argument requires the presence of a Windows <-> Unix path tool to be present to be used to convert, for e.g.,LIBenvironment variable with Windows libraries search paths to its equivalent in the Unix system it is running on (e.g. Cygwin with native Windows or Linux with Wine). It can be either guessed from the current Unix system or set using theCCCL_WINPATH_BINenvironment variable.The operations of
print-search-dirsrequire the manipulation of Windows paths, namely separating the Windows path prefix from the path, to shorten the Unix version of the path, and parsing the Windows path prefix from the path is a bit tedious. So, I relied on Python'spathlib'sPureWindowsPath(and alsoPurePosixPathfor manipulating Unix paths) to resolve this issue without implementing this functionality in pure Bash scripting. However, I would have to add a Python requirement to the script as well, withCCCL_PYTHON_BINenvironment variable to set it to a custom Python installation path or resolved from thePATHenvironment variable. Though recent versions of Linux or Cygwin installation already comes with Python (even native Windows Python should work in this case), and Python is being as available by default as Perl. Also, the library I require, which ispathlib, is already part of the standard library of recent Python versions.