Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/module): Allow TypeScript nodes for Rewriter #9606

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 2, 2024

@kdy1 kdy1 added this to the Planned milestone Oct 2, 2024
@kdy1 kdy1 self-assigned this Oct 2, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 2, 2024 06:00
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 4f1fc09

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 2, 2024 06:00
@kdy1 kdy1 disabled auto-merge October 2, 2024 06:00
@kdy1 kdy1 changed the title fix(es/modules): Allow TypeScript nodes for Rewriter fix(es/module): Allow TypeScript nodes for Rewriter Oct 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 2, 2024 06:00
@kdy1 kdy1 disabled auto-merge October 2, 2024 06:24
@kdy1 kdy1 merged commit 4ee45ac into swc-project:main Oct 2, 2024
153 checks passed
@kdy1 kdy1 deleted the issue-9592 branch October 2, 2024 06:24
@kdy1 kdy1 modified the milestones: Planned, v1.7.29 Oct 2, 2024
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #9606 will degrade performances by 5.15%

Comparing kdy1:issue-9592 (ba3e820) with main (b94a0e1)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 174 untouched benchmarks

🆕 16 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9592 Change
es/full/bugs-1 530.1 µs 555.3 µs -4.53%
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false N/A 1.3 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true N/A 1.4 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false N/A 1.6 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true N/A 1.7 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false N/A 84.2 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true N/A 84.6 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=false N/A 116.4 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=true N/A 114.2 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=false N/A 13.8 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=true N/A 13.8 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=false N/A 18.4 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=true N/A 18.3 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=false N/A 7.5 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=true N/A 8.4 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=true/reactDev=false N/A 9.6 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=true/reactDev=true N/A 10.8 ms N/A
es/full/codegen/es2015 276.6 µs 291.6 µs -5.15%
serialization of serde 2.9 µs 2.8 µs +3.13%
es/visitor/base-perf/boxing_unboxed 3.3 µs 3.4 µs -3.43%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build project after updating @swc/core to 1.7.28
1 participant