Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/codegen): Reduce usage of tracing::instrument #9604

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 2, 2024

@kdy1 kdy1 added this to the Planned milestone Oct 2, 2024
@kdy1 kdy1 self-assigned this Oct 2, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 2, 2024 05:45
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 8e74e3a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 2, 2024 05:45
@kdy1 kdy1 disabled auto-merge October 2, 2024 06:09
@kdy1 kdy1 merged commit 2f06fc5 into swc-project:main Oct 2, 2024
153 checks passed
@kdy1 kdy1 deleted the perf-codegen branch October 2, 2024 06:10
@kdy1 kdy1 modified the milestones: Planned, v1.7.29 Oct 2, 2024
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #9604 will improve performances by 9.55%

Comparing kdy1:perf-codegen (af351e0) with main (b94a0e1)

Summary

⚡ 13 improvements
✅ 165 untouched benchmarks

🆕 16 new benchmarks

Benchmarks breakdown

Benchmark main kdy1:perf-codegen Change
es/full/bugs-1 530.1 µs 507.3 µs +4.48%
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false N/A 1.2 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true N/A 1.4 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false N/A 1.5 ms N/A
🆕 es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true N/A 1.7 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false N/A 82.1 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true N/A 83 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=false N/A 114.4 ms N/A
🆕 es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=true N/A 112.4 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=false N/A 13.4 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=true N/A 13.5 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=false N/A 17.9 ms N/A
🆕 es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=true N/A 18 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=false N/A 7.3 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=true N/A 8.3 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=true/reactDev=false N/A 9.5 ms N/A
🆕 es/oxc/benches/assets/table.tsx/sourceMap=true/reactDev=true N/A 10.6 ms N/A
es/full/codegen/es2016 285.5 µs 262.4 µs +8.79%
es/full/codegen/es2017 280.6 µs 257.8 µs +8.84%
es/full/codegen/es2018 281 µs 258 µs +8.91%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

perf: JsWriter of ES codegen involves atomic load due to tracing
1 participant