-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(swc): trying to verify swc_core with local pkg #5452
Conversation
d3055f3
to
40d1578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should not be a js test.
It will cause headaches while publishing
Will it? theoritically this'll ensure test catches in PR level. |
Yep, you can use |
Before digging further, would like to hear workflow which'll break publishing. The main goal of this PR is (if it works correctly)
If using plain js is not right place, where would be a good place? I don't think where / how to execute it changes the way it works in this PR but I may wrong. |
We run all js tests before publishing the node package. |
But test doesn't do anything with node.js package, am I missing something? |
No, |
I think there's some lacks of explanation in this PR. After this PR, test will be expanded
latter definitely needs node.js environment, the only thing we do not do is explicitly will-be-published node.js binding version install which'll obviously fail. |
We don't need all platform for such task. Using linux is enough |
If you really want to use js testing system, please create another PR using |
I would argue #5406 is counterproof. Currently this only happens on certain machine type, in result linux CI / windows CI never caught this. |
Also, when creating another PR, please expand platform matrix of node js integration test so we can catch issues while normal review process |
We're now using swc_core public version, so we can check this when we build binding_*. |
Description:
This PR attempts to add another set of e2e test to ensure missing version bump in some transitive deps, which are not able to be caught in current CI as it uses path resolutions all the time.
Idea's straightforward, for the pkgs we'd like to ensure (
swc_core
), make a compile test to build against locally packed (cargo package
) instead of path resolution. generated pkg will try to behave as close to actually published one without path resolution, so we can catch some of build time errors before publish.Depends on usefulness plan to grow test more, especially some regression tests between @swc/core to plugin for the newly published pkg. This is bit headache with existing plugins (swc-coverage-instrument) and having test will help future regressions.
BREAKING CHANGE:
Related issue (if exists):