Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swc): temporarily disable bytecheck #5414

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Aug 7, 2022

Description:

Reverts #5062 partially to amend #5406 as a workaround.

This is not a correct fix, since issue itself is quite tricky it requires time to investigate & create some reliable repro steps - meanwhile this PR unblocks existing users. This means potential delay to AST schema version support.

BREAKING CHANGE:

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Aug 7, 2022

This requires to release new @swc/core also.

@kdy1 kdy1 added this to the Planned milestone Aug 8, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_atoms --breaking

@kdy1 kdy1 enabled auto-merge (squash) August 8, 2022 01:44
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2b5080e into swc-project:main Aug 8, 2022
@kwonoj kwonoj deleted the disable-bytecheck branch August 8, 2022 05:53
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants