Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(register): resolve builtin modules without node: protocal #803

Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix(register): resolve builtin modules without node: protocal #803

merged 2 commits into from
Jul 5, 2024

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn force-pushed the 07-05-fix_register_resolve_builtin_modules_without_node_protocal branch from 0a7caf2 to a893650 Compare July 5, 2024 07:43
@Brooooooklyn Brooooooklyn merged commit a4a6832 into master Jul 5, 2024
7 checks passed
@Brooooooklyn Brooooooklyn deleted the 07-05-fix_register_resolve_builtin_modules_without_node_protocal branch July 5, 2024 07:46
@weyert
Copy link

weyert commented Jul 6, 2024

@Brooooooklyn Can't we use require('node:module').builtinModules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New version (1.10.1) is broken
2 participants
@Brooooooklyn @weyert