Don't output source maps if sourceMaps option is omitted or false #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefee
commented
Oct 8, 2021
| sourceMaps: undefined | swc.Options['sourceMaps'] | ||
| sourceMaps: swc.Options['sourceMaps'] |
There was a problem hiding this comment.
undefined | isn't needed because swc.Options['sourceMaps'] is already optional
kdy1
requested changes
Oct 8, 2021
| @@ -11,7 +11,7 @@ const { | |||
| } = promises; | |||
|
|
|||
| function withSourceMap(output: Output, options: Options, destFile: string, destDir: string) { | |||
| if (!output.map || options.sourceMaps === "inline") { | |||
| if (!output.map || !options.sourceMaps || options.sourceMaps === "inline") { | |||
There was a problem hiding this comment.
This will @swc/cli not generate sourcemap even if sourceMaps: true is specified in .swcrc.
There was a problem hiding this comment.
I see - the issue must be swc core is not reading the sourceMaps: false from swcrc file correctly (and it must also be default to true not false)
| ) { | ||
| const destDir = dirname(filename); | ||
| mkdirSync(destDir, { recursive: true }); | ||
|
|
||
| let code = output.code; | ||
| if (output.map && sourceMaps !== "inline") { | ||
| if (output.map && sourceMaps && sourceMaps !== "inline") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
Reverts regression in #68