Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input/keyboard: extend bindsym --to-code to work with duplicate matches #8358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

input/keyboard: extend bindsym --to-code to work with duplicate matches #8358

wants to merge 1 commit into from

Commits on Sep 23, 2024

  1. input/keyboard: extend bindsym --to-code to work with duplicate matches 

    This modifies `get_active_binding` to treat bindsym --to-codes
separately: per each keysym `i` in `binding->keys`, look through the list of
matching keycodes in `binding->translations[i]`.

Another solution is to take the cartesian product of all syms and make a
binding per each product. This makes retranslation more difficult though
because the dups from the old layout have to be cleared out before
translating to the new `xkb_layout`. Whether by retaining a parent
binding, searching through all bindings for matching `binding->command`,
or some other ref count structure, that would introduce more complexity
than modifying get_active binding to account for dups. Notice this
requires no changes to the existing retranslation logic.
    @sahinf
    sahinf committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    db0c5b7 View commit details
    Browse the repository at this point in the history