Include wlroots checkout helper for bisecting #8347
Conversation
|
|
||
| wlroots = pygit2.Repository("subprojects/wlroots") | ||
| master = wlroots.revparse_single("master") | ||
| for commit in wlroots.walk(master.id, pygit2.enums.SortMode.TIME): |
There was a problem hiding this comment.
I'm not sure if using the time is always the right thing here, have you encountered any issue with that so far?
There was a problem hiding this comment.
I'm not sure if using the time is always the right thing here
In this context, TIME is the commit time specifically, which is the time when the commit was merged into the master branch.
The time shown by git log is the author time. Using that one does not work; it yields bogus results since some commits are authored months before being merged.
have you encountered any issue with that so far?
When wlroots version N is released, the version is immediately bumped to N+1. From that point on, meson will complain that it has wlroots N+1 but expects version N.
In my experience bisecting sway, very few commits have this issue. Usually I skip these. If you need to dive into that range, you'll can just check out the wlroots tag.
I find this useful when bisecting, since the latest wlroots usually won't work on older sway commits.
Hopefully it can help others too.