commands/move: Focus inactive view when no parent is found #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases where the inactive view is the null container that wraps tabbed and stacking layouts. The following demonstrates how this results in some unexpected behavior: 1. On an empty workspace, spawn three windows. 2. Convert the layout to stacking with `layout stacking`. 3. Toggle one of the windows as floating with `toggle floating`. 4. With the floating window still selected, move it to another workspace with `move container to workspace`. We'd expect just one window to be selected instead of all remaining windows in the workspace. We can fix this by selecting the inactive view instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where the inactive view is the null container that wraps tabbed and stacking layouts. The following demonstrates how this results in some unexpected behavior:
layout stacking.toggle floating.move container to workspace.We'd expect just one window to be selected instead of all remaining windows in the workspace. We can fix this by selecting the inactive view instead.