Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring unfocused tab title #8174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shengdichen
Copy link

Hi sway devs:

This pull request allows configuration of the unfocused tab/stack container title (shortened to tab-title henceforth) independent from the generic unfocused tab-title. The resultant configuration option is called client.unfocused_tab_title.

A driving motivation for this is the quick visual distinction of an (unfocused) view and an (unfocused) container.

The implementation closely mirrors that of the existing option of the focused tab-title client.focused_tab_title. The documentation update is made in a separate, second commit.

Thanks for looking over this!

@emersion
Copy link
Member

Hi, thanks for sending a patch! Does this option exist in i3 as well, or is this something completely new? Note that in general our focus is not to add new window management features, see https://github.com/swaywm/sway/blob/master/CONTRIBUTING.md#scope-of-future-changes-to-sway

@shengdichen
Copy link
Author

Hi, thanks for the quick response!

No, sadly the option proposed here does not exist in i3 currently. I submitted this patch since:

  • it was not a feature expansion to the core window management facilities;
  • it seemed like a natural (to me) extension of an existing option.

I would be glad to see this merged, but of course I understand and respect sway's mission statement. In the case of not merging, should I try to submit a patch to i3 and see if they would accept this feature? And if it gets merged in i3, will this be open for discussion again here in sway?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants