added 'disable_titlebar' option #8026

neuromagus · 2024-03-01T09:45:36Z

I fix my previous commit to master branch.

My patch fixed this issue #7409 (comment)

and you fixed the rendering so my patch is more trivial. Amazing work, guys.

WhyNotHugo · 2024-03-01T14:35:15Z

I would like to see the ability to toggle this on a per-window basis (much like we can toggle floating per-window).

That said, I have absolutely no objection to this approach being merged.

neuromagus · 2024-03-01T15:41:44Z

@WhyNotHugo

I would like to see the ability to toggle this on a per-window basis (much like we can toggle floating per-window).

Hmm, why not? Particularly this commit focused on total disable any titlebars. IMO, need to add another option and (new commit) way for hotkey with toggle behavior switcher. If need this stuff, again, why not?

For example - press Mod+t - disable titlebar on focused window? Am I right?

P.S. My English is so terrible, sorry for that.

y0nei · 2024-03-01T21:40:15Z

We need this

neuromagus · 2024-03-02T16:00:39Z

@y0nei watch this

neuromagus · 2024-03-04T16:43:33Z

Following feedback from @y0nei, this pull request need to be update to render the top border if the titlebar is not ~~render~~ visible. In my patch for 1.9 version this behavior fixed.

I think I'll fix it here later... Sway 1.9 came out a week or two ago xD and I prefer stable version of Wlroots, because Wlroots-dev did not like my mpv player...

neuromagus · 2024-03-07T14:16:44Z

@Nefsen402. I need a help with this patch. In this commit 869baff u reorganize structure of Sway project (clear sway/desktop/ folder, and this is amazing (removed render behind scene)) and move render to the sway/desktop/transaction.c. Maybe I'm wrong and the render is located in a different place. So here it says a big tree with a rendering boundary (NONE, PIXEL, NORMAL), titlebar and stuff. I see, u are trying to fix removing or not rendering the Titlebar. Here in the master manpage:

*border* none|normal|csd|pixel [<n>]
    Set border style for focused window. _normal_ includes a border of
    thickness _n_ and a title bar. _pixel_ is a border without title bar _n_
    pixels thick. Default is _normal_ with border thickness 2. _csd_ is short
    for client-side-decorations, which allows the client to draw its own
    decorations.

This behavior did not work for me. For example i set in config default_border pixel 10 - Titlebar showed. With my hack (this pull request) for rendering "top border" need to be added (t/f my option) for rendering top border which will complicate the design of an already complex code, IMHO.

I mean, maybe this area (line 288 static void arrange_children() and line 381, static void arrange_container()) needs refactoring? Here is my diff for Sway1.9

Sorry, this is my first request and I don't know the rules or form for making such requests.

Nefsen402 · 2024-03-07T14:26:50Z

container_titlebar_height is only used when using the B_NORMAL mode for borders. B_PIXEL will use a size determined by container->current.border_top. I think your patch should have correct behavior if instead of trying to change container_titlebar_height in any way. This should instead work:

diff --git a/sway/desktop/transaction.c b/sway/desktop/transaction.c
index 042141ab..4895add1 100644
--- a/sway/desktop/transaction.c
+++ b/sway/desktop/transaction.c
@@ -392,6 +392,10 @@ static void arrange_container(struct sway_container *con,
                int border_top = container_titlebar_height();
                int border_width = con->current.border_thickness;
 
+               if (wants to disable title bar) {
+                       title_bar = false;
+               }
+
                if (title_bar && con->current.border != B_NORMAL) {
                        wlr_scene_node_set_enabled(&con->title_bar.tree->node, false);
                        wlr_scene_node_set_enabled(&con->border.top->node, true);

However, it might be beneficial to keep the current behavior. The top border size can be manually set to 0 by the user if they truly don't want any top decorations of any kind.

neuromagus · 2024-03-07T14:43:31Z

Thanks for the quick and detailed answer. Not everything is so clear here. For your recommendation top border did not showed if we remove titlebar, because rendering happens below. titlebar = false doesn't allow me to use the if (title_bar... blah-blah) where rendering border_top.

So, I'm stuck, need copy render func in this construction

if (wants to disable title bar) {
    title_bar = false;
    border_top = blah-blah
    ...
    wlr_scene_node_set_enabled(&con->border.top->node, true);
}

or insert inside "if" more checking?

} else if (con->current.border != B_NORMAL && config->disable-titlebar) {
   //copy here code for initial size and render border_top
}

Again. Borders shows in NORMAL and PIXEL modes. If i disable titlebar in this modes showed empty space without color where we want see border_top

neuromagus · 2024-03-07T18:08:48Z

@Nefsen402

However, it might be beneficial to keep the current behavior. The top border size can be manually set to 0 by the user if they truly don't want any top decorations of any kind.

After researching and testing TABBED mode with borders, I found this configuration to be unfortunate for this mode, the borders made it difficult to hit the scrollbar by mouse...

So maybe, but not necessary to be fixed manpages to recommend options with disable_titlebar (default_border none, default_floating_border none/pixel 2 etc) and that's it.

tmpm697 · 2024-03-28T05:12:41Z

I'm looking forward for at least to disable title on tabbed window as that the currently use case for me.

neuromagus · 2024-03-28T08:30:29Z

use working solution today, @tmpm697 xD - https://github.com/neuromagus/disable_titlebar_in_sway

tmpm697 · 2024-03-28T11:01:26Z

tks @neuromagus , hope it merged soon, critical to one of my favourite workflow.

quincyf467 · 2024-03-31T19:06:57Z

Thanks for patch! Works as intended

tormath1 · 2024-04-18T07:32:07Z

Hey folks, I tested this patch against sway-1.9, it compiles and works fine. Great job! I still see a titlebar when the window opacity is set to < 1. Is that expected or? Here's the rendering + configuration: https://gist.github.com/tormath1/3188521f928f4584d2363ce5eb416858

neuromagus · 2024-04-18T07:42:22Z

@tormath1 yes, master and 1.9 - are different beasts. Use this version for normal work.

tormath1 · 2024-04-18T08:39:37Z

@neuromagus thanks for sharing the 1.9 patch, it works as expected. Looking forward to see this merged and sorry for the noise 🙇

emersion · 2024-05-08T13:29:01Z

In terms of command design:

The term "titlebar" refers to the whole window decoration, including borders. Maybe using "title" instead would be more accurate? (This would be consistent with e.g. "title_format")
Do we want a new command, or do we want to special-case the empty string for "title_format"? It may be desirable for users to have a titlebar with no contents, however that could be achieved with a space character, for instance…
Do we want to extend "default_border" instead?

neuromagus · 2024-05-08T18:28:21Z

The term "titlebar" refers to the whole window decoration, including borders. Maybe using "title" instead would be more accurate? (This would be consistent with e.g. "title_format")

why not?

Do we want a new command, or do we want to special-case the empty string for "title_format"? It may be desirable for users to have a titlebar with no contents, however that could be achieved with a space character, for instance…

I think it's better to remove titlebars completely, no "empty strings", just remove (before we used a hack with font 0 and... better disable titlebar completely (don't allocate window space, don't call a function for format Titlebar et cetera), IMO) :} What do you think?

Do we want to extend "default_border" instead?

This is separate entity, IMHO. Someone want borders without titlebars...
Should I add all this to my patch or you could make the adjustments yourself in Sway?
I only want to use Sway with no "Titlebars" (on any layouts).

neuromagus · 2024-05-08T18:49:43Z

@emersion
something wrong with Wlroots in build farm (testing Archlinux)!

Cloning into 'wlroots'...
fatal: unable to access 'https://gitlab.freedesktop.org/wlroots/wlroots.git/': The requested URL returned error: 504
[#1215763] 2024/05/08 16:03:16 Failed to clone git repository. If this a private repository, make sure you've added a suitable SSH key.

fossdd · 2024-05-08T18:52:14Z

something wrong with Wlroots for testing (archlinux)!

thats a issue on your side, working perfectly with my internet connection.

neuromagus · 2024-05-08T19:07:25Z

thats a issue on your side, working perfectly with my internet connection.

ok, how to restart build test?

kennylevinsen · 2024-07-12T18:33:19Z

The term "titlebar" refers to the whole window decoration, including borders. Maybe using "title" instead would be more accurate? (This would be consistent with e.g. "title_format")

To nitpick, a titlebar has "padding", and a window has either a top border (border pixel) or a titlebar (border normal, or in stacking/tabbed mode).

I imagine users want the border pixel behavior, but for stacking/tabbed.

Do we want to extend "default_border" instead?

This is separate entity, IMHO. Someone want borders without titlebars... Should I add all this to my patch or you could make the adjustments yourself in Sway? I only want to use Sway with no "Titlebars" (on any layouts).

The border command currently controls the titlebar behavior for everything but stack/tabbed views. The options are:

none: No border and no titlebar
normal: Border (left, right, bottom) and titlebar
pixel: Border (left, right, top, bottom) with no titlebar
csd: No border and no titlebar, client-side decorations requested to replace titlebar

The problem is that stacking and tabbed do not respect pixel or none, and instead behave as if the border was set to normal instead (with 0 width in case of none).

In that sense, the goal is not to "disable the titlebar" - we have two toggles for that already in border - but to have a way to have a container that has stacking behavior that respects border none|pixel. We can either:

Have a new always_pixel/always_none border mode which also applies to tabbed/stacking.
Have a grouped_titlebar always|follow_border setting to control whether the titlebar for stacking/tabbed should respect border pixel or not. Or, if we wanted to get fancy, titlebar splitv|splith|stacking|tabbed always|never|follow_border.
Have a new container type like stacking/tabbed, but dedicated to the "swallow" use-case without navigation UI.

The second option would probably be the easiest to wire up. I don't mind the last option either, but it has IPC consequences and might not be worth it.

EDIT: Expanded the border examples to also cover the different behavior for none.

neuromagus · 2024-07-12T19:03:28Z

pixel: Border (left, right, top, bottom) with no titlebar

IMO, need a simpler config name. "pixel"?

The problem is that stacking and tabbed do not respect pixel, and instead behave as if the border was set to normal instead.

this is not a problem. If you disable the titlebar, you create (or render) container with respects new rules. Sorry for my eng, how this stuff realized in Sway:
if you have a titlebar - u add in container static pixel size (padding, font size, border size etc). I just add a hack - "disable titlebar" -> this size equals to zero.

In my opinion - option "disable titlebar" need to set alone, border size set to another config group. Maybe later we need to update titlebar render, some containers show titlebar, some not...

kennylevinsen · 2024-07-12T20:23:45Z

IMO, need a simpler config name. "pixel"?

Those are the existing names from i3, so changing those is not an option.

this is not a problem. If you disable the titlebar, you create (or render) container with respects new rules. Sorry for my eng, how this stuff realized in Sway:
if you have a titlebar - u add in container static pixel size (padding, font size, border size etc). I just add a hack - "disable titlebar" -> this size equals to zero.

The linked issues are all about having titlebar also be removed for stacking/tabbed layout, because you can already do this for everything else.

Bugs aside (including not reinstalling the top border when removing the titlebar), this also the only functional difference your PR provides over border pixel/border none.

In my opinion - option "disable titlebar" need to set alone, border size set to another config group. Maybe later we need to update titlebar render, some containers show titlebar, some not...

The titlebar is already controlled by the border setting except for stacking/tabbed. I don't think we want two ways to show/hide the titlebar, just a way to have the setting also apply to stacking/tabbed layouts.

WhyNotHugo · 2024-07-12T20:38:39Z

I imagine users want the border pixel behavior, but for stacking/tabbed.

Personally, I wouldn't mind seeing the top border for tabbed windows too. It always felt kind of weird that tabbed windows only have three (right, left, bottom) borders).

The titlebar is already controlled by the border setting except for stacking/tabbed. I don't think we want two ways to show/hide the titlebar, just a way to have the setting also apply to stacking/tabbed layouts.

Perhaps we want a setting to enable/disable titlebars for containers, since tabbed titlebars actually belong to the container itself, no?

neuromagus · 2024-07-12T20:41:58Z

The titlebar is already controlled by the border setting except for stacking/tabbed. I don't think we want two ways to show/hide the titlebar, just a way to have the setting also apply to stacking/tabbed layouts.

Nice to read this. Well, we need to add this functionality to "stacking/tabbed" or other layouts (set global behavior)!.. And maybe add hotkey for enable/disable titlebar for this and only this container(window)?

Perhaps we want a setting to enable/disable titlebars for containers, since tabbed titlebars actually belong to the container itself, no?

ah ;}

kennylevinsen · 2024-07-12T22:00:30Z

Perhaps we want a setting to enable/disable titlebars for containers, since tabbed titlebars actually belong to the container itself, no?

In case of stacked/tabbed, the titlebar for children is drawn by the parent container, whereas for splitv/splith/floating, the titlebar is drawn by the child containers.

That's also just an implementation detail, from the user perspective the titlebar is above the child container regardless of how it got there.

neuromagus · 2024-07-12T22:07:53Z

That's also just an implementation detail, from the user perspective the titlebar is above the child container regardless of how it got there.

yep.

added 'disable_titlebar' option

e1bd348

This was referenced Mar 1, 2024

Added disable_titlebar option in Sway v1.9 #8023

Closed

Hide the titlebar #7409

Open

Merge branch 'swaywm:master' into disable_titlebar

b57879f

Merge branch 'master' into disable_titlebar

74fcb60

Merge branch 'master' into disable_titlebar

af5c748

neuromagus added 2 commits March 31, 2024 23:17

Merge branch 'master' into disable_titlebar

abce7e5

Merge branch 'master' into disable_titlebar

034fbb5

vwyu approved these changes Apr 10, 2024

View reviewed changes

Merge branch 'master' into disable_titlebar

cf60851

neuromagus added 3 commits April 22, 2024 22:55

Merge branch 'master' into disable_titlebar

ff9c5aa

Merge branch 'master' into disable_titlebar

8c8f009

Merge branch 'master' into disable_titlebar

79ff8d4

Merge branch 'master' into disable_titlebar

e23e621

Merge branch 'master' into disable_titlebar

f8461bf

kennylevinsen mentioned this pull request Jul 13, 2024

Introduce grouped_titlebar command #8248

Open

neuromagus closed this by deleting the head repository Jul 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added 'disable_titlebar' option #8026

added 'disable_titlebar' option #8026

neuromagus commented Mar 1, 2024 •

edited

Loading

WhyNotHugo commented Mar 1, 2024 •

edited

Loading

neuromagus commented Mar 1, 2024 •

edited

Loading

y0nei commented Mar 1, 2024

neuromagus commented Mar 2, 2024

neuromagus commented Mar 4, 2024 •

edited

Loading

neuromagus commented Mar 7, 2024

Nefsen402 commented Mar 7, 2024

neuromagus commented Mar 7, 2024 •

edited

Loading

neuromagus commented Mar 7, 2024

tmpm697 commented Mar 28, 2024

neuromagus commented Mar 28, 2024

tmpm697 commented Mar 28, 2024

quincyf467 commented Mar 31, 2024

tormath1 commented Apr 18, 2024

neuromagus commented Apr 18, 2024 •

edited

Loading

tormath1 commented Apr 18, 2024

emersion commented May 8, 2024

neuromagus commented May 8, 2024 •

edited

Loading

neuromagus commented May 8, 2024 •

edited

Loading

fossdd commented May 8, 2024

neuromagus commented May 8, 2024

kennylevinsen commented Jul 12, 2024 •

edited

Loading

neuromagus commented Jul 12, 2024 •

edited

Loading

kennylevinsen commented Jul 12, 2024

WhyNotHugo commented Jul 12, 2024

neuromagus commented Jul 12, 2024 •

edited

Loading

kennylevinsen commented Jul 12, 2024

neuromagus commented Jul 12, 2024

added 'disable_titlebar' option #8026

added 'disable_titlebar' option #8026

Conversation

neuromagus commented Mar 1, 2024 • edited Loading

WhyNotHugo commented Mar 1, 2024 • edited Loading

neuromagus commented Mar 1, 2024 • edited Loading

y0nei commented Mar 1, 2024

neuromagus commented Mar 2, 2024

neuromagus commented Mar 4, 2024 • edited Loading

neuromagus commented Mar 7, 2024

Nefsen402 commented Mar 7, 2024

neuromagus commented Mar 7, 2024 • edited Loading

neuromagus commented Mar 7, 2024

tmpm697 commented Mar 28, 2024

neuromagus commented Mar 28, 2024

tmpm697 commented Mar 28, 2024

quincyf467 commented Mar 31, 2024

tormath1 commented Apr 18, 2024

neuromagus commented Apr 18, 2024 • edited Loading

tormath1 commented Apr 18, 2024

emersion commented May 8, 2024

neuromagus commented May 8, 2024 • edited Loading

neuromagus commented May 8, 2024 • edited Loading

fossdd commented May 8, 2024

neuromagus commented May 8, 2024

kennylevinsen commented Jul 12, 2024 • edited Loading

neuromagus commented Jul 12, 2024 • edited Loading

kennylevinsen commented Jul 12, 2024

WhyNotHugo commented Jul 12, 2024

neuromagus commented Jul 12, 2024 • edited Loading

kennylevinsen commented Jul 12, 2024

neuromagus commented Jul 12, 2024

neuromagus commented Mar 1, 2024 •

edited

Loading

WhyNotHugo commented Mar 1, 2024 •

edited

Loading

neuromagus commented Mar 1, 2024 •

edited

Loading

neuromagus commented Mar 4, 2024 •

edited

Loading

neuromagus commented Mar 7, 2024 •

edited

Loading

neuromagus commented Apr 18, 2024 •

edited

Loading

neuromagus commented May 8, 2024 •

edited

Loading

neuromagus commented May 8, 2024 •

edited

Loading

kennylevinsen commented Jul 12, 2024 •

edited

Loading

neuromagus commented Jul 12, 2024 •

edited

Loading

neuromagus commented Jul 12, 2024 •

edited

Loading