fullscreen: init floating on disable without size #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
approved these changes
Mar 10, 2019
|
@minus7 does this fix your issue? |
|
The window size isn't zero anymore, but until I move the window, mpv's content is larger than the window: Xfce4-terminal plays nice with it tough (yes this does fix the immediate issue) Thanks for the quick fix, @RedSoxFan |
RedSoxFan
force-pushed
the
fix-fs-map-float-criteria
branch
from
cb94242
to
f9e2503
Compare
|
@minus7 can you try again? |
|
No change |
RedSoxFan
force-pushed
the
fix-fs-map-float-criteria
branch
from
f9e2503
to
493c057
Compare
|
@minus7 how about now? |
emersion
reviewed
Mar 10, 2019
If a container gets mapped as fullscreen and set to floating by criteria, the size and location are never set for the floating container. This adds a check in container_fullscreen_disable for a width or height of 0 and calls container_init_floating
RedSoxFan
force-pushed
the
fix-fs-map-float-criteria
branch
from
493c057
to
9b58659
Compare
On IRC, it was determined that this only happens when |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3850
If a container gets mapped as fullscreen and set to floating by
criteria, the size and location are never set for the floating
container. This adds a check in container_fullscreen_disable for a
width or height of 0 and calls container_init_floating
Note that the content may be smaller than the container due to the
natural size being larger than the maximum floating size and the
client giving a smaller surface of the same aspect ratio. I think
this is related to #2176 (or at least the discussion in the issue)