This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
Change from __dirname to process.cwd() #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using swagger-node from Docker and are using a local copy of the swagger script from `./node_modules/.bin/swagger` to run `./node_modules/.bin/swagger project edit`. This doesn't serve `swagger-editor` correctly as `__dirname` resolves to `./node_modules/swagger` as this is where the script is running. We've made the above change to use `process.cwd()` so that we can reference swagger-editor correctly.
|
...any updates on this? Looks like the build is failing for some other reason than our changes. We've tested this locally and from within our docker container. |
|
You can try to run the tests again after rebasing from or merging in master? Should be fixed with 5bb2539 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using swagger-node from Docker and are using a local copy of the swagger script from
./node_modules/.bin/swaggerto run./node_modules/.bin/swagger project edit. This doesn't serveswagger-editorcorrectly as__dirnameresolves to./node_modules/swaggeras this is where the script is running. We've made the above change to useprocess.cwd()so that we can reference swagger-editor correctly.