Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(team-map): replaces 'ajv' with a hand-rolled validation #211

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jun 3, 2024

Description

  • replaces the validation of the team map in ajv with a simple hand-rolled one
  • removes the 3rd party production dependency 'ajv'

Motivation and Context

Less dependencies = less worries. Ajv is b.t.w. a great & well maintained package, but for validating the tiny team maps it's overkill. It also makes virtual-code-owners' footprint smaller (ajv is ~120kb minified/ ~35kb compressed - compared to vco itself which has the numbers ~27kb/ ~9kb).

How Has This Been Tested?

  • green ci
  • additional non-regression integration tests (we have to test a bit more now, but also the error messages can be easier made to fit to our use case).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@github-actions github-actions bot added the vco label Jun 3, 2024
@McMeadow McMeadow changed the title refactor(team-map): replaces 'ajv' with a simple hand validation refactor(team-map): replaces 'ajv' with a simple hand-rolled validation Jun 3, 2024
@sverweij sverweij changed the title refactor(team-map): replaces 'ajv' with a simple hand-rolled validation refactor(team-map): replaces 'ajv' with a hand-rolled validation Jun 3, 2024
@sverweij sverweij merged commit f9f6e0f into main Jun 3, 2024
9 checks passed
@sverweij sverweij deleted the refactor/hand-validate-team-map branch June 3, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants