-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for [sections] - GitLab style #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
vco-admins
vco
admin
labels
May 11, 2024
McMeadow
reviewed
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition - you might want to look at .github/CODEOWNERS
which still seems to contain test data, though
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
McMeadow
reviewed
May 11, 2024
Co-authored-by: Lex McMeadow <[email protected]>
sverweij
force-pushed
the
feature/adds-support-for-sections
branch
from
May 11, 2024 18:55
6340f48
to
b89fc04
Compare
sverweij
force-pushed
the
feature/adds-support-for-sections
branch
from
May 11, 2024 19:15
c1eaee1
to
c225876
Compare
McMeadow
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They're not illegal on GitHub (CODEOWNERS with them do check out OK), but I'm not sure
they're actually supported yet.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️