Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for [sections] - GitLab style #204

Merged
merged 5 commits into from
May 11, 2024
Merged

feat: adds support for [sections] - GitLab style #204

merged 5 commits into from
May 11, 2024

Conversation

sverweij
Copy link
Owner

Description

  • Adds support for sections as in use in GitLab
    They're not illegal on GitHub (CODEOWNERS with them do check out OK), but I'm not sure
    they're actually supported yet.

Motivation and Context

  • They're 'legal' parts of a CODEOWNERS file both GitHub and on GitLab (and on GitLab they have a documented meaning). Before this PR the virtual-codeowners parser would most of the time reject lines with sections as 'unkown' syntax.
  • Sections can contain group names that need to be expanded in CODEOWNERS

How Has This Been Tested?

  • green ci
  • Additional unit/ integration tests & expanded corpus

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it

  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij requested a review from McMeadow as a code owner May 11, 2024 17:57
@github-actions github-actions bot added documentation Improvements or additions to documentation vco-admins vco admin labels May 11, 2024
McMeadow
McMeadow reviewed May 11, 2024
View reviewed changes
Copy link
Collaborator

@McMeadow McMeadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition - you might want to look at .github/CODEOWNERS which still seems to contain test data, though

McMeadow
McMeadow reviewed May 11, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
McMeadow
McMeadow reviewed May 11, 2024
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
McMeadow
McMeadow reviewed May 11, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sverweij sverweij force-pushed the feature/adds-support-for-sections branch from 6340f48 to b89fc04 Compare May 11, 2024 18:55
@sverweij sverweij force-pushed the feature/adds-support-for-sections branch from c1eaee1 to c225876 Compare May 11, 2024 19:15
McMeadow
McMeadow approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@McMeadow McMeadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@McMeadow McMeadow merged commit d93e45b into main May 11, 2024
7 checks passed
@McMeadow McMeadow deleted the feature/adds-support-for-sections branch May 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McMeadow McMeadow McMeadow approved these changes

Assignees
No one assigned
Labels
admin documentation Improvements or additions to documentation vco vco-admins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverweij @McMeadow