Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix prettier lint error in src/exports/public.d.ts #12877

Closed

Conversation

aloisklink
Copy link
Contributor

Run:

npx prettier --write src/exports/public.d.ts

This should fix the failing lint CI actions on the main branch.

Fixes: f9a9816 (looks like we forgot to run prettier here)
Fixes: #12876 (comment)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
    • I ran pnpm lint && pnpm check and everything passes.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
    • Styling only change.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Run:

```
npx prettier --write src/exports/public.d.ts
```

Fixes: f9a9816
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 6ddb809

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Because this also affects the generated types apparently, could you commit those as well?

@aloisklink
Copy link
Contributor Author

aloisklink commented Oct 25, 2024

Oh, this PR doesn't fix the issue. It looks like the generated types from npm run generate:types are unprettified, which causes lint errors.

I'm guessing we'd need to either update packages/kit/scripts/generate-dts.js or https://github.com/Rich-Harris/dts-buddy to prettify these files then (or make prettier ignore these generated files).

Because this also affects the generated types apparently, could you commit those as well?

Unfortunately, it looks like the pnpm run lint expects packages/kit/src/exports/public.d.ts to be prettified. But the Generated types have changed — please run prepublishOnly locally and commit the changes after you have reviewed them CI check expects this file to be unprettified, so there's a conflict!

@aloisklink aloisklink closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants