Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defer when clicking hash links with data-sveltekit-reload #12866

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 23, 2024

fixes #12582
fixes #12188

Replaces #10032 by using location.replace to allow the browser to handle hash link behaviour instead #10856 (comment)

This PR ensures that clicking on a hash link with the reload option avoids the usual behaviour of thinking the page will reload and instead allows it to be handled as if the option wasn't enabled (hash links on the same page never reload the page).

It also fixes a behaviour where an element doesn't get focused when clicking on the hash link more than once.

TODO:

  • fix behaviour where clicking a hash link twice doesn't focus the input

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: fd0a3aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: defer to browser when clicking hash links fix: defer when clicking hash links with data-sveltekit-reload Oct 23, 2024
@eltigerchino eltigerchino changed the title fix: defer when clicking hash links with data-sveltekit-reload fix: do not reload when clicking hash links with data-sveltekit-reload Oct 23, 2024
@eltigerchino eltigerchino changed the title fix: do not reload when clicking hash links with data-sveltekit-reload fix: defer when clicking hash links with data-sveltekit-reload Oct 23, 2024
@eltigerchino eltigerchino marked this pull request as draft October 23, 2024 09:14
@eltigerchino eltigerchino marked this pull request as ready for review October 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants