Replace pay_to_email with merchant_code in Checkout creation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of using
pay_to_emailinstead of the recommendedmerchant_codein the Checkout creation process.Changes made:
createmethod insrc/SumUp/Services/Checkouts.php:$payToEmailto$merchantCode$payToEmailmerchant_codeinstead ofpay_to_emailThese changes align the SDK with the current API recommendations as per https://developer.sumup.com/api/checkouts/create#checkouts-create.
Note: This change may break backward compatibility for applications using the current version of the SDK. Consider incrementing the major version number and providing migration instructions in the changelog.
Please review and let me know if any further changes are needed.
#46