-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the global style reset #2237
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Codecov Report
@@ Coverage Diff @@
## main #2237 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 251 251
Lines 19750 19750
Branches 1198 1198
=======================================
Hits 19149 19149
Misses 581 581
Partials 20 20 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed. |
I'm back from my sabbatical and will continue working on this PR soon. |
Purpose
CSS resets are used to reduce browser inconsistencies in things like default line heights, margins and font sizes of headings, and so on. All browsers have presentation defaults, but no browsers have the same defaults.
Circuit UI’s global base styles are pretty opinionated and can clash with other frameworks or styles used on a page. This pull request aims to reduce or remove the global styles to prevent these kinds of conflicts. It will be an opt-in change.
Approach and changes
Describe how you solved the problem
Definition of done