Bug select few annotations in one item navigate to another item breaks #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 25, 2024 15:36
… variants and show the list correctly
…tem only if target is not null
…the new variants list is shown
|
@paulpestov the last two commits are the contribution of this PR. The others are part of the other PR. |
paulpestov
reviewed
Oct 25, 2024
|
|
||
|
|
||
| // when target is null -> we switched to another item - we don't continue and change the level of highlight of the text | ||
| if (target) { |
There was a problem hiding this comment.
if (!target) return ...But we have to come back here after the release.
|
Please don't add unnecessary commit to PRs anymore, you can do the merge afterwards. Look at the main-variants branch, it has now 2 duplicated 'update configs' commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.