-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce visible annotations in variants #500
Introduce visible annotations in variants #500
Conversation
…nt visible Annotations, instead of filteredAnnotations
…lect mode by using visibleAnnotations
5b654dc
to
86b5107
Compare
Please add tests for switching between annotation tabs and the variant tab, also switching between different text panel tabs + variant tab. By introducing |
…itching Variant and Editorial annotation tabs
…tence of annotations
@paulpestov regarding your screenshot above: The witness value for a certain annotation is null, therefore it brings an error while setting a color to the variant item. |
use visibleAnnotations to show the current visible annotations, instead of filteredAnnotations.
Filtered annotations should contain the annotations for the current visible tab.
Visible annotations should contain only the current visible annotations, i.e when switching the single select mode on, it should be empty. When we click at a target and i.e 4 annotations are shown in the list, then visible annotations should contain only these annotations.