Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce visible annotations in variants #500

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

orlinmalkja
Copy link
Contributor

use visibleAnnotations to show the current visible annotations, instead of filteredAnnotations.

Filtered annotations should contain the annotations for the current visible tab.
Visible annotations should contain only the current visible annotations, i.e when switching the single select mode on, it should be empty. When we click at a target and i.e 4 annotations are shown in the list, then visible annotations should contain only these annotations.

@orlinmalkja orlinmalkja force-pushed the introduce-visible-annotations-in-variants branch from 5b654dc to 86b5107 Compare October 22, 2024 13:35
@orlinmalkja orlinmalkja removed the request for review from paulpestov October 22, 2024 14:55
@paulpestov
Copy link
Collaborator

paulpestov commented Oct 22, 2024

Please add tests for switching between annotation tabs and the variant tab, also switching between different text panel tabs + variant tab. By introducing visibleAnnotations in the store, I cannot overview the consequences right now. I thought visibleAnnotations would be a local variable inside of VariantView where the changes to filteredAnnotations would have been bypassed to. But now it is a whole new state management.

@paulpestov
Copy link
Collaborator

paulpestov commented Oct 23, 2024

I also see this when I open the arabic-karshuni page with the Dev endpoint (it's the first item in the first manifest):
Screenshot 2024-10-23 110255

@orlinmalkja orlinmalkja self-assigned this Oct 23, 2024
@orlinmalkja
Copy link
Contributor Author

@paulpestov regarding your screenshot above: The witness value for a certain annotation is null, therefore it brings an error while setting a color to the variant item.

@orlinmalkja orlinmalkja merged commit e294bc1 into main-variants Oct 23, 2024
2 checks passed
@orlinmalkja orlinmalkja deleted the introduce-visible-annotations-in-variants branch October 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants