-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove bug in addWitness() when target is the only child element…
…, add checks for null/array length, make cleaner the functions in annotations.js related to variants * fix: remove the witness only when there is 'witnesses' html element in text panel * fix: restructure addWitness() to avoid the bug when target is the only child of its parent * fix: add checks on witnesses array to avoid bugs * fix: remove bug when target is null * fix: show the variants top bar only when there are filteredAnnotations for the variants tab * fix: do not emit a click on text, when it is not an annotation target * refactor: improve the code which updates the parentHtml el when we add a witness * refactor: add early return statement in allocateWitnessColorInVariantItem * chore: remove the if condition on showing the witnesses filter * refactor: clean addWitness() function * refactor: check the existence of witnesses Html in removeWitness() * refactor: add early return in getWitnessesHtmlEl() * refactor: restructure better addWitness and remove 'html' from variable names * refactor: remove unused functions and added checks on (null or zero-length) arrays * docs: reason why witnesses wrapper is on the same child level as target in addWitnesses() * refactor: make createWitnessEl function consistent * refactor: make several functions in annotations.js more consistent --------- Co-authored-by: malkja <[email protected]>
- Loading branch information
1 parent
8216d4f
commit 14263e5
Showing
5 changed files
with
91 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters