Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to use latest duckdb and modify groupby relation tests #109

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: update to use latest duckdb and modify groupby relation tests #109

merged 2 commits into from
Sep 24, 2024

Conversation

richtia
Copy link
Member

@richtia richtia commented Sep 19, 2024 •
edited
Loading

Mostly updates to duckdb produced substrait plans.

Made the SQL for groupby relations (groupby, rollup, cube) more similar
so it's easier to understand the differences when comparing substrait plans

@richtia richtia marked this pull request as ready for review September 20, 2024 16:22
EpsilonPrime
EpsilonPrime approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over half of the changes were the version marker changing. It would be nice to exclude that from the difference so that we don't have to review all of the files every time a backend updates the Substrait dependency.

@richtia richtia merged commit b540812 into substrait-io:main Sep 24, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richtia @EpsilonPrime