Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update isthmus tpch substrait plans #105

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: update isthmus tpch substrait plans #105

merged 2 commits into from
Sep 12, 2024

Conversation

richtia
Copy link
Member

@richtia richtia commented Sep 11, 2024

No description provided.

EpsilonPrime
EpsilonPrime approved these changes Sep 12, 2024
View reviewed changes
substrait_consumer/tests/integration/queries/tpch_substrait_plans/query_2_plan.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could name the plans with a leading zero so they sort properly.

@richtia richtia marked this pull request as ready for review September 12, 2024 02:11
@richtia richtia changed the title fix: update isthmus substrait plans fix: update isthmus tpch substrait plans Sep 12, 2024
@richtia richtia merged commit 76e9b8f into substrait-io:main Sep 12, 2024
4 of 12 checks passed
@vbarua vbarua mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@vbarua vbarua Awaiting requested review from vbarua

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richtia @EpsilonPrime