mock: in order mock calls

[ReyOrtiz]

Summary

Add helper method to declare the order of the mock calls.

Changes

• add InOrder(calls ...*Call) helper method to declare the order of mock calls by calling NotBefore()

Motivation

This is probably the only feature I miss from gomock.InOrder(), it is more intuitive and cleaner to declare the order of the mock calls. Probably most cases can be satisfied with this method.

InOrder(
	mockedService1.On("TheExampleMethod", 1, 2, 3).Return(4, nil),
	mockedService2.On("TheExampleMethod2", true).Return(),
	mockedService3.On("TheExampleMethod3", "abc", 3).Return(false, nil),
)

Related issues

Closes #1639

[brackendawson]

Can we get a unit test, please.

[ReyOrtiz]

unit test added

[brackendawson]

Positive and negative tests, nice one. 👍 Just a couple of small comments.

[brackendawson]

This line is testing the implementation. A cost effective test would only test the behaviour, as you are doing just fine after this line.

If you remove this assertion then we are free to change the implementation of the intended behaviour without breaking the test. It also removes the need to declare b and c, so the test can be written as InOrder is intended to be used.

[brackendawson]

Also, it's just comparing pointer values. If InOrder did literally nothing then that assertion would still pass.

[ReyOrtiz]

Good comments, thanks! Requested changes applied.

[brackendawson]

Looks good to me, should be helpful to all the developers moving from gomock. I'll give some time for other maintainers to review before I merge.

[jybp]

Ah you beat me to it, thanks! And missed that existing PR

[ReyOrtiz]

Hello, any ETA on merging this PR?

[brackendawson]

Thanks @ReyOrtiz. This can be consumed now by gomock expats with: go get github.com/stretchr/testify@master. Once testify v1.10 is released it can be consumed as per the README. I'll have a look at drafting a release soon.

[ReyOrtiz]

Thanks @brackendawson for all the help! 🙏