Add Helper() method in internal mocks and assert.CollectT #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
changed the title
dolmen
added
pkg-mock
dolmen
added
TB.Helper
dolmen
force-pushed
the
add-Helper-method-in-tests
branch
from
1d5a0dd
to
f79712c
Compare
Add an Helper() method to all mocks in tests of package 'assert'.
Add Helper() method to CollectT like testing.T as we intend to add Helper() to the assert.TestingT interface.
dolmen
force-pushed
the
add-Helper-method-in-tests
branch
from
f79712c
to
da99481
Compare
craig65535
approved these changes
Oct 31, 2023
| @@ -1874,6 +1874,9 @@ type CollectT struct { | |||
| errors []error | |||
| } | |||
|
|
|||
| // Helper is like [testing.T.Helper] but does nothing. | |||
| func (CollectT) Helper() {} | |||
There was a problem hiding this comment.
Should the newly merged captureTestingT also get a Helper() method? (Or, should captureTestingT be replaced with CollectT?)
brackendawson
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Given this doesn't change the interface I don't want to block progress, so approving.
But I think @craig65535 is right, ideally re-base this and add consolidate the new internal type using one of those approaches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start to extend our definition of
testing.TBto include itsHelper()method. See #1422 for details.Changes
Helper()method on all internal mocks oftesting.T.Helper()method on typeassert.CollectT.Motivation
These are steps 1 and 2 of #1422.