Use %v when formatting objects in assert.Len #1086
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
assert.Len
's error message for non-%s
able values.Details
It was using %s, which doesn't work if the thing being len'ed is not a
[]string
or similar. For example,assert.Len(t, []int{1}, 0)
saysthat
[%!s(int=1)] should have 1 item(s), but has 0
. Now it uses%v
which will work for almost anything.