Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide to whether use pulsarctl based on image name #669

Merged

Conversation

jiangpengcheng
Copy link
Member

@jiangpengcheng jiangpengcheng commented Jul 21, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #629

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Use pulsarctl when runner image name contains pulsar-functions-pulsarctl-(java|go|python)-runner, so users don't need to pass the imageHasPulsarctl manually

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners July 21, 2023 02:20
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 21, 2023
nlu90
nlu90 previously approved these changes Aug 9, 2023
freeznet
freeznet previously approved these changes Aug 9, 2023
@jiangpengcheng jiangpengcheng dismissed stale reviews from freeznet and nlu90 via 9aae9e8 August 10, 2023 02:14
@jiangpengcheng jiangpengcheng merged commit a3952c6 into streamnative:master Aug 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2023-08 no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants