Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support YAML config for java runtime, support log format json for java and python #667

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Jul 18, 2023

Fixes #661

Motivation

allow user to select xml or yaml for java log4j config file extension.

Modifications

  • add Format to RuntimeLogConfig
  • add JavaLog4JConfigFileType to RuntimeLogConfig

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested a review from nlu90 as a code owner July 18, 2023 09:23
@freeznet freeznet self-assigned this Jul 18, 2023
@freeznet freeznet requested a review from a team as a code owner July 18, 2023 09:23
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 18, 2023
@freeznet freeznet requested a review from labuladong July 18, 2023 09:23
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Jul 18, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the doc-required This pr needs a document label Jul 18, 2023
nlu90
nlu90 previously approved these changes Jul 25, 2023
controllers/spec/function.go Outdated Show resolved Hide resolved
@freeznet freeznet merged commit e1b7128 into master Jul 25, 2023
13 checks passed
@freeznet freeznet deleted the freeznet/support-yaml-log-configs branch July 25, 2023 06:48
@Huanli-Meng Huanli-Meng added doc-added and removed doc-required This pr needs a document labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support YAML format for log4j
3 participants