add codecov upload action in coverage.yaml #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 1197/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,133.00 | 📈 view plot | 473.00 | 📈 view plot | 733.00 | 📈 view plot | 7.00 | 📈 view plot | 39.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,166.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,161.00 | 📈 view plot | 35.00 | 📈 view plot | 138.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,293.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,548.00 | 📈 view plot | 21.00 | 📈 view plot | 104.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,678.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,758.00 | 📈 view plot | 44.00 | 📈 view plot | 220.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,472.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,402.00 | 📈 view plot | 83.00 | 📈 view plot | 333.00 |
| client_sv2_open_channel | 📈 view plot | 4,375.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,160.00 | 📈 view plot | 9.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,986.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,326.00 | 📈 view plot | 37.00 | 📈 view plot | 185.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,647.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,672.00 | 📈 view plot | 81.00 | 📈 view plot | 302.00 |
| client_sv2_setup_connection | 📈 view plot | 4,715.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,275.00 | 📈 view plot | 12.00 | 📈 view plot | 68.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,148.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,663.00 | 📈 view plot | 41.00 | 📈 view plot | 208.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,542.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,817.00 | 📈 view plot | 99.00 | 📈 view plot | 378.00 |
|
| Branch | 1197/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.44 |
| client_sv2_handle_message_mining | 📈 view plot | 74.38 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.58 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 251.10 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 596.87 |
| client_sv2_open_channel | 📈 view plot | 166.27 |
| client_sv2_open_channel_serialize | 📈 view plot | 280.82 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 374.73 |
| client_sv2_setup_connection | 📈 view plot | 161.03 |
| client_sv2_setup_connection_serialize | 📈 view plot | 462.92 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 922.25 |
|
| Branch | 1197/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,402.00 | 📈 view plot | 3,746.00 | 📈 view plot | 5,252.00 | 📈 view plot | 7.00 | 📈 view plot | 89.00 |
| get_submit | 📈 view plot | 95,369.00 | 📈 view plot | 59,439.00 | 📈 view plot | 85,364.00 | 📈 view plot | 48.00 | 📈 view plot | 279.00 |
| get_subscribe | 📈 view plot | 8,029.00 | 📈 view plot | 2,841.00 | 📈 view plot | 3,969.00 | 📈 view plot | 14.00 | 📈 view plot | 114.00 |
| serialize_authorize | 📈 view plot | 12,249.00 | 📈 view plot | 5,317.00 | 📈 view plot | 7,414.00 | 📈 view plot | 8.00 | 📈 view plot | 137.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,743.00 | 📈 view plot | 9,868.00 | 📈 view plot | 13,928.00 | 📈 view plot | 35.00 | 📈 view plot | 304.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,440.00 | 📈 view plot | 12,071.00 | 📈 view plot | 17,090.00 | 📈 view plot | 59.00 | 📈 view plot | 373.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,624.00 | 📈 view plot | 73,280.00 | 📈 view plot | 105,049.00 | 📈 view plot | 108.00 | 📈 view plot | 601.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 28,066.00 | 📈 view plot | 9,659.00 | 📈 view plot | 13,656.00 | 📈 view plot | 68.00 | 📈 view plot | 402.00 |
| serialize_deserialize_submit | 📈 view plot | 115,315.00 | 📈 view plot | 68,057.00 | 📈 view plot | 97,645.00 | 📈 view plot | 69.00 | 📈 view plot | 495.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,447.00 | 📈 view plot | 8,211.00 | 📈 view plot | 11,562.00 | 📈 view plot | 39.00 | 📈 view plot | 334.00 |
| serialize_submit | 📈 view plot | 99,830.00 | 📈 view plot | 61,483.00 | 📈 view plot | 88,205.00 | 📈 view plot | 50.00 | 📈 view plot | 325.00 |
| serialize_subscribe | 📈 view plot | 11,430.00 | 📈 view plot | 4,188.00 | 📈 view plot | 5,825.00 | 📈 view plot | 15.00 | 📈 view plot | 158.00 |
|
Have you been able to test it in some way? |
Trying to configure act locally to test the flow once. |
Shourya742
force-pushed
the
2024-10-revive-codecov
branch
2 times, most recently
from
049b651
to
295dd81
Compare
plebhash
reviewed
Oct 9, 2024
Shourya742
force-pushed
the
2024-10-revive-codecov
branch
3 times, most recently
from
a2c4b6d
to
3a5aa1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
===========================================
- Coverage 37.40% 19.36% -18.04%
===========================================
Files 152 164 +12
Lines 14556 10811 -3745
===========================================
- Hits 5444 2094 -3350
+ Misses 9112 8717 -395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GitGab19
approved these changes
Oct 10, 2024
jbesraa
reviewed
Oct 10, 2024
Shourya742
force-pushed
the
2024-10-revive-codecov
branch
from
3a5aa1f
to
f6bb0c7
Compare
pavlenex
force-pushed
the
2024-10-revive-codecov
branch
3 times, most recently
from
0fb91d6
to
bf3cf2c
Compare
rrybarczyk
approved these changes
Oct 10, 2024
pavlenex
force-pushed
the
2024-10-revive-codecov
branch
from
fcbe307
to
adb953d
Compare
Shourya742
force-pushed
the
2024-10-revive-codecov
branch
from
adb953d
to
77d6c13
Compare
Shourya742
force-pushed
the
2024-10-revive-codecov
branch
from
77d6c13
to
5deebd4
Compare
GitGab19
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1196