Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lib versioning script #1114

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 19, 2024

ever since we merged #985, we now have a CI fully dedicated to enforcing SemVer for all PRs against dev and main

that essentially makes scripts/check-versioning-lib-release.sh obsolete, so it is being removed via f883bde

however, the failure of this script was a safeguard that would prevent any libs from being published to crates.io

if we only removed the script, that would still leave the possibility of publishing crates that failed SemVer CI, which is undesirable

so b3dde39 is making sure release-libs only runs if the PR to main was actually merged

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 19:45:59 UTC
ProjectStratum v2 (SRI)
Branchrm-lib-versioning-script
Testbedsv1

🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)298.00 (+1.07%)297.91 (100.03%)
serialize_deserialize_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)323.00 (+1.35%)322.34 (100.20%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,507.00 (+0.89%)8,743.15 (97.30%)✅ (view plot)3,772.00 (+0.85%)3,864.13 (97.62%)✅ (view plot)5,297.00 (+0.98%)5,414.13 (97.84%)✅ (view plot)5.00 (-34.92%)10.62 (47.10%)✅ (view plot)91.00 (+1.19%)94.18 (96.62%)
get_submit✅ (view plot)95,684.00 (+0.14%)96,165.15 (99.50%)✅ (view plot)59,522.00 (+0.08%)59,777.50 (99.57%)✅ (view plot)85,499.00 (+0.10%)85,836.69 (99.61%)✅ (view plot)49.00 (-10.56%)62.48 (78.42%)✅ (view plot)284.00 (+0.74%)288.70 (98.37%)
get_subscribe✅ (view plot)8,068.00 (+1.15%)8,298.39 (97.22%)✅ (view plot)2,848.00 (+0.71%)2,947.98 (96.61%)✅ (view plot)3,983.00 (+0.80%)4,110.61 (96.90%)✅ (view plot)12.00 (-24.69%)20.04 (59.87%)✅ (view plot)115.00 (+2.03%)117.49 (97.88%)
serialize_authorize✅ (view plot)12,358.00 (+1.21%)12,540.83 (98.54%)✅ (view plot)5,343.00 (+0.60%)5,435.13 (98.30%)✅ (view plot)7,458.00 (+0.67%)7,577.04 (98.43%)✅ (view plot)7.00 (-33.23%)13.79 (50.75%)✅ (view plot)139.00 (+2.43%)141.00 (98.58%)
serialize_deserialize_authorize✅ (view plot)24,636.00 (+0.67%)24,731.44 (99.61%)✅ (view plot)9,950.00 (+0.48%)10,036.41 (99.14%)✅ (view plot)14,051.00 (+0.57%)14,166.62 (99.18%)✅ (view plot)31.00 (-14.84%)41.74 (74.26%)🚨 (view plot | view alert)298.00 (+1.07%)297.91 (100.03%)
serialize_deserialize_handle_authorize✅ (view plot)30,232.00 (+0.31%)30,373.39 (99.53%)✅ (view plot)12,127.00 (+0.26%)12,219.13 (99.25%)✅ (view plot)17,167.00 (+0.29%)17,290.98 (99.28%)✅ (view plot)58.00 (-1.64%)65.03 (89.19%)✅ (view plot)365.00 (+0.38%)367.11 (99.42%)
serialize_deserialize_handle_submit✅ (view plot)126,571.00 (+0.13%)127,067.24 (99.61%)✅ (view plot)73,307.00 (+0.08%)73,622.10 (99.57%)✅ (view plot)105,096.00 (+0.10%)105,517.42 (99.60%)✅ (view plot)109.00 (-8.79%)131.84 (82.67%)✅ (view plot)598.00 (+0.56%)600.40 (99.60%)
serialize_deserialize_handle_subscribe✅ (view plot)27,542.00 (+0.33%)27,646.04 (99.62%)✅ (view plot)9,650.00 (+0.21%)9,749.98 (98.97%)✅ (view plot)13,652.00 (+0.23%)13,785.61 (99.03%)✅ (view plot)62.00 (-5.99%)73.59 (84.25%)✅ (view plot)388.00 (+0.59%)388.94 (99.76%)
serialize_deserialize_submit✅ (view plot)115,367.00 (+0.24%)115,684.21 (99.73%)✅ (view plot)68,167.00 (+0.15%)68,409.04 (99.65%)✅ (view plot)97,842.00 (+0.18%)98,166.17 (99.67%)✅ (view plot)61.00 (-11.64%)75.99 (80.28%)✅ (view plot)492.00 (+0.82%)493.43 (99.71%)
serialize_deserialize_subscribe✅ (view plot)23,054.00 (+0.76%)23,146.20 (99.60%)✅ (view plot)8,209.00 (+0.30%)8,305.91 (98.83%)✅ (view plot)11,564.00 (+0.31%)11,694.01 (98.89%)✅ (view plot)37.00 (-5.93%)43.88 (84.32%)🚨 (view plot | view alert)323.00 (+1.35%)322.34 (100.20%)
serialize_submit✅ (view plot)100,091.00 (+0.19%)100,504.98 (99.59%)✅ (view plot)61,566.00 (+0.08%)61,826.48 (99.58%)✅ (view plot)88,346.00 (+0.10%)88,689.85 (99.61%)✅ (view plot)46.00 (-16.77%)63.01 (73.00%)✅ (view plot)329.00 (+1.31%)330.99 (99.40%)
serialize_subscribe✅ (view plot)11,507.00 (+1.52%)11,656.15 (98.72%)✅ (view plot)4,195.00 (+0.48%)4,294.98 (97.67%)✅ (view plot)5,837.00 (+0.48%)5,969.30 (97.78%)✅ (view plot)14.00 (-13.76%)19.06 (73.45%)✅ (view plot)160.00 (+2.86%)161.01 (99.38%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 19:45:59 UTC
ProjectStratum v2 (SRI)
Branch1114/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,475.50 (-6.14%)7,378.29 (87.76%)
client-submit-serialize-deserialize✅ (view plot)7,503.40 (-4.16%)8,349.37 (89.87%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,128.00 (-3.16%)8,862.45 (91.71%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)922.15 (+2.59%)927.22 (99.45%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)698.71 (+0.28%)716.65 (97.50%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)250.04 (+0.82%)254.94 (98.08%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.58 (+0.29%)162.15 (97.18%)
client-sv1-get-submit✅ (view plot)6,231.90 (-6.44%)7,177.42 (86.83%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)285.10 (+2.19%)291.42 (97.83%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)761.03 (+1.71%)776.77 (97.97%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)601.26 (-2.25%)639.51 (94.02%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)206.94 (+0.22%)219.24 (94.39%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 19:45:57 UTC
ProjectStratum v2 (SRI)
Branchrm-lib-versioning-script
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.14 (-0.93%)45.24 (97.56%)
client_sv2_handle_message_mining✅ (view plot)76.00 (+3.96%)80.86 (93.99%)
client_sv2_mining_message_submit_standard✅ (view plot)14.64 (-0.08%)14.69 (99.65%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)272.53 (+3.02%)283.38 (96.17%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)587.71 (-1.02%)626.26 (93.84%)
client_sv2_open_channel✅ (view plot)166.06 (+0.34%)171.34 (96.92%)
client_sv2_open_channel_serialize✅ (view plot)279.19 (-1.28%)293.50 (95.12%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)375.77 (-0.62%)421.64 (89.12%)
client_sv2_setup_connection✅ (view plot)156.60 (-4.63%)174.85 (89.56%)
client_sv2_setup_connection_serialize✅ (view plot)461.80 (-2.35%)504.51 (91.53%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)949.18 (-2.40%)1,042.56 (91.04%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 19:45:58 UTC
ProjectStratum v2 (SRI)
Branchrm-lib-versioning-script
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)1,999.00 (-2.69%)2,141.36 (93.35%)✅ (view plot)445.00 (-5.40%)487.01 (91.37%)✅ (view plot)694.00 (-5.13%)755.92 (91.81%)✅ (view plot)9.00 (+26.73%)11.04 (81.52%)✅ (view plot)36.00 (-2.12%)38.90 (92.54%)
client_sv2_handle_message_mining✅ (view plot)8,251.00 (+0.63%)8,334.64 (99.00%)✅ (view plot)2,143.00 (+0.68%)2,171.69 (98.68%)✅ (view plot)3,166.00 (+0.62%)3,216.06 (98.44%)✅ (view plot)37.00 (-3.49%)43.35 (85.36%)✅ (view plot)140.00 (+0.79%)141.91 (98.65%)
client_sv2_mining_message_submit_standard✅ (view plot)6,224.00 (-0.86%)6,392.13 (97.37%)✅ (view plot)1,728.00 (-1.23%)1,764.34 (97.94%)✅ (view plot)2,519.00 (-1.35%)2,576.56 (97.77%)✅ (view plot)20.00 (+12.60%)23.25 (86.02%)✅ (view plot)103.00 (-0.85%)106.88 (96.37%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,689.00 (-0.62%)15,027.72 (97.75%)✅ (view plot)4,672.00 (-0.46%)4,708.34 (99.23%)✅ (view plot)6,724.00 (-0.45%)6,776.00 (99.23%)✅ (view plot)46.00 (-2.62%)51.65 (89.06%)✅ (view plot)221.00 (-0.70%)229.74 (96.20%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,475.00 (-0.05%)27,847.05 (98.66%)✅ (view plot)10,563.00 (+0.17%)10,576.41 (99.87%)✅ (view plot)15,370.00 (+0.17%)15,384.69 (99.90%)✅ (view plot)83.00 (-0.95%)89.25 (93.00%)✅ (view plot)334.00 (-0.31%)345.08 (96.79%)
client_sv2_open_channel✅ (view plot)4,271.00 (-4.73%)4,626.48 (92.32%)✅ (view plot)1,433.00 (-1.83%)1,475.28 (97.13%)✅ (view plot)2,121.00 (-1.46%)2,173.61 (97.58%)✅ (view plot)10.00 (-16.78%)15.22 (65.71%)✅ (view plot)60.00 (-7.52%)68.63 (87.42%)
client_sv2_open_channel_serialize✅ (view plot)13,960.00 (-1.77%)14,456.27 (96.57%)✅ (view plot)5,036.00 (-0.53%)5,078.28 (99.17%)✅ (view plot)7,290.00 (-0.38%)7,339.62 (99.32%)✅ (view plot)32.00 (-13.59%)41.44 (77.21%)✅ (view plot)186.00 (-2.95%)198.63 (93.64%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,543.00 (-0.46%)23,016.08 (97.94%)✅ (view plot)7,999.00 (+0.16%)8,015.43 (99.80%)✅ (view plot)11,633.00 (+0.14%)11,654.18 (99.82%)✅ (view plot)82.00 (+10.81%)83.75 (97.91%)✅ (view plot)300.00 (-1.50%)314.55 (95.37%)
client_sv2_setup_connection✅ (view plot)4,599.00 (-2.12%)4,768.45 (96.45%)✅ (view plot)1,474.00 (-1.78%)1,516.28 (97.21%)✅ (view plot)2,239.00 (-1.63%)2,300.25 (97.34%)✅ (view plot)10.00 (+7.08%)14.36 (69.63%)✅ (view plot)66.00 (-2.77%)69.61 (94.81%)
client_sv2_setup_connection_serialize✅ (view plot)16,060.00 (-1.27%)16,481.45 (97.44%)✅ (view plot)5,935.00 (-0.45%)5,977.28 (99.29%)✅ (view plot)8,620.00 (-0.39%)8,677.56 (99.34%)✅ (view plot)46.00 (+2.15%)50.15 (91.72%)✅ (view plot)206.00 (-2.41%)217.13 (94.87%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,434.00 (-0.30%)35,746.71 (99.13%)✅ (view plot)14,827.00 (+0.09%)14,842.97 (99.89%)✅ (view plot)21,779.00 (+0.11%)21,794.32 (99.93%)✅ (view plot)99.00 (-0.83%)112.35 (88.12%)✅ (view plot)376.00 (-0.96%)384.28 (97.84%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash changed the title Remove lib versioning script + set SemVer safeguards to release-libs.yaml Remove lib versioning script Aug 19, 2024
@plebhash plebhash merged commit 0f0ee1e into stratum-mining:dev Aug 19, 2024
33 checks passed
@plebhash plebhash deleted the rm-lib-versioning-script branch August 19, 2024 20:19
@plebhash plebhash mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants