Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG Test on quick templates #1026

Closed

Conversation

Shourya742
Copy link
Contributor

Closes #923

Work in Progress:

  1. Added JDS mock
  2. Added TP mock
  3. Added TProxy mock

Current State:
The process currently encounters an issue where it gets stuck at the declareMiningJob step. Debugging in progress.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🐰Bencher

ReportFri, July 19, 2024 at 11:45:28 UTC
ProjectStratum v2 (SRI)
Branchfeat/multipleTemplateMGTest
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.54 (-0.05%)45.24 (98.45%)
client_sv2_handle_message_mining✅ (view plot)75.35 (+3.39%)80.43 (93.68%)
client_sv2_mining_message_submit_standard✅ (view plot)14.65 (-0.02%)14.69 (99.71%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)253.03 (-4.27%)284.30 (89.00%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)570.05 (-4.01%)628.10 (90.76%)
client_sv2_open_channel✅ (view plot)166.18 (+0.13%)173.47 (95.80%)
client_sv2_open_channel_serialize✅ (view plot)271.11 (-4.17%)293.65 (92.32%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)371.85 (-1.69%)423.84 (87.73%)
client_sv2_setup_connection✅ (view plot)159.97 (-2.50%)174.88 (91.48%)
client_sv2_setup_connection_serialize✅ (view plot)458.78 (-3.22%)506.58 (90.56%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)1,007.90 (+3.71%)1,040.54 (96.86%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🐰Bencher

ReportFri, July 19, 2024 at 11:45:25 UTC
ProjectStratum v2 (SRI)
Branchfeat/multipleTemplateMGTest
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,430.00 (-0.05%)8,723.53 (96.64%)✅ (view plot)3,718.00 (-0.59%)3,855.36 (96.44%)✅ (view plot)5,210.00 (-0.65%)5,401.71 (96.45%)✅ (view plot)7.00 (-11.90%)10.40 (67.31%)✅ (view plot)91.00 (+1.09%)93.98 (96.83%)
get_submit✅ (view plot)95,401.00 (-0.16%)96,143.37 (99.23%)✅ (view plot)59,411.00 (-0.10%)59,779.47 (99.38%)✅ (view plot)85,321.00 (-0.10%)85,837.78 (99.40%)✅ (view plot)49.00 (-11.09%)62.58 (78.30%)✅ (view plot)281.00 (-0.38%)287.70 (97.67%)
get_subscribe✅ (view plot)7,883.00 (-1.16%)8,271.13 (95.31%)✅ (view plot)2,813.00 (-0.58%)2,939.66 (95.69%)✅ (view plot)3,933.00 (-0.51%)4,099.29 (95.94%)✅ (view plot)13.00 (-19.66%)19.82 (65.60%)✅ (view plot)111.00 (-1.44%)116.95 (94.91%)
serialize_authorize✅ (view plot)12,183.00 (-0.18%)12,502.29 (97.45%)✅ (view plot)5,289.00 (-0.41%)5,426.36 (97.47%)✅ (view plot)7,373.00 (-0.46%)7,565.04 (97.46%)✅ (view plot)10.00 (-7.41%)13.38 (74.73%)✅ (view plot)136.00 (+0.34%)140.21 (97.00%)
serialize_deserialize_authorize✅ (view plot)24,480.00 (+0.05%)24,706.94 (99.08%)✅ (view plot)9,870.00 (-0.30%)10,026.45 (98.44%)✅ (view plot)13,920.00 (-0.33%)14,151.51 (98.36%)✅ (view plot)33.00 (-9.79%)41.62 (79.29%)✅ (view plot)297.00 (+0.73%)297.76 (99.74%)
serialize_deserialize_handle_authorize✅ (view plot)30,219.00 (+0.24%)30,340.67 (99.60%)✅ (view plot)12,073.00 (-0.18%)12,210.36 (98.88%)✅ (view plot)17,079.00 (-0.22%)17,280.23 (98.84%)✅ (view plot)59.00 (+0.37%)64.70 (91.19%)✅ (view plot)367.00 (+0.86%)367.08 (99.98%)
serialize_deserialize_handle_submit✅ (view plot)126,406.00 (-0.00%)127,033.73 (99.51%)✅ (view plot)73,224.00 (-0.04%)73,621.57 (99.46%)✅ (view plot)104,946.00 (-0.04%)105,513.86 (99.46%)✅ (view plot)120.00 (-0.42%)131.31 (91.38%)✅ (view plot)596.00 (+0.19%)599.24 (99.46%)
serialize_deserialize_handle_subscribe✅ (view plot)27,383.00 (-0.26%)27,601.70 (99.21%)✅ (view plot)9,615.00 (-0.17%)9,741.66 (98.70%)✅ (view plot)13,603.00 (-0.14%)13,775.28 (98.75%)✅ (view plot)61.00 (-7.40%)73.85 (82.60%)✅ (view plot)385.00 (-0.20%)388.54 (99.09%)
serialize_deserialize_submit✅ (view plot)114,999.00 (-0.07%)115,655.20 (99.43%)✅ (view plot)68,001.00 (-0.08%)68,404.14 (99.41%)✅ (view plot)97,559.00 (-0.09%)98,152.61 (99.40%)✅ (view plot)65.00 (-6.39%)75.30 (86.32%)✅ (view plot)489.00 (+0.18%)492.39 (99.31%)
serialize_deserialize_subscribe✅ (view plot)22,814.00 (-0.26%)23,111.23 (98.71%)✅ (view plot)8,167.00 (-0.22%)8,297.44 (98.43%)✅ (view plot)11,504.00 (-0.21%)11,682.72 (98.47%)✅ (view plot)36.00 (-8.63%)44.09 (81.65%)✅ (view plot)318.00 (-0.16%)321.48 (98.92%)
serialize_submit✅ (view plot)99,718.00 (-0.18%)100,471.87 (99.25%)✅ (view plot)61,455.00 (-0.10%)61,828.88 (99.40%)✅ (view plot)88,168.00 (-0.09%)88,691.32 (99.41%)✅ (view plot)49.00 (-12.04%)62.30 (78.65%)✅ (view plot)323.00 (-0.51%)329.20 (98.12%)
serialize_subscribe✅ (view plot)11,220.00 (-0.93%)11,607.35 (96.66%)✅ (view plot)4,160.00 (-0.39%)4,286.66 (97.05%)✅ (view plot)5,790.00 (-0.37%)5,958.54 (97.17%)✅ (view plot)15.00 (-8.33%)18.98 (79.05%)✅ (view plot)153.00 (-1.42%)159.78 (95.75%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🐰Bencher

ReportFri, July 19, 2024 at 11:45:28 UTC
ProjectStratum v2 (SRI)
Branchfeat/multipleTemplateMGTest
Testbedsv2

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)23.00 (+30.74%)22.95 (100.24%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)1,991.00 (-2.80%)2,127.05 (93.60%)✅ (view plot)445.00 (-5.36%)487.47 (91.29%)✅ (view plot)696.00 (-4.85%)756.75 (91.97%)✅ (view plot)7.00 (+0.80%)10.73 (65.22%)✅ (view plot)36.00 (-1.72%)38.54 (93.40%)
client_sv2_handle_message_mining✅ (view plot)8,219.00 (+0.27%)8,336.65 (98.59%)✅ (view plot)2,137.00 (+0.46%)2,171.37 (98.42%)✅ (view plot)3,159.00 (+0.46%)3,216.13 (98.22%)✅ (view plot)39.00 (+1.20%)43.61 (89.43%)✅ (view plot)139.00 (+0.11%)141.98 (97.90%)
client_sv2_mining_message_submit_standard✅ (view plot)6,196.00 (-1.24%)6,389.07 (96.98%)✅ (view plot)1,722.00 (-1.54%)1,764.74 (97.58%)✅ (view plot)2,511.00 (-1.65%)2,578.28 (97.39%)🚨 (view plot | view alert)23.00 (+30.74%)22.95 (100.24%)✅ (view plot)102.00 (-1.73%)106.92 (95.40%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,537.00 (-1.58%)15,038.43 (96.67%)✅ (view plot)4,666.00 (-0.58%)4,708.74 (99.09%)✅ (view plot)6,717.00 (-0.54%)6,777.16 (99.11%)✅ (view plot)52.00 (+9.77%)52.44 (99.17%)✅ (view plot)216.00 (-2.83%)230.08 (93.88%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,349.00 (-0.46%)27,843.66 (98.22%)✅ (view plot)10,557.00 (+0.14%)10,563.94 (99.93%)✅ (view plot)15,364.00 (+0.15%)15,369.28 (99.97%)✅ (view plot)87.00 (+3.85%)89.47 (97.23%)✅ (view plot)330.00 (-1.42%)345.32 (95.56%)
client_sv2_open_channel✅ (view plot)4,331.00 (-3.52%)4,616.37 (93.82%)✅ (view plot)1,433.00 (-1.83%)1,475.89 (97.09%)✅ (view plot)2,121.00 (-1.44%)2,174.24 (97.55%)✅ (view plot)8.00 (-32.81%)15.35 (52.11%)✅ (view plot)62.00 (-4.72%)68.24 (90.86%)
client_sv2_open_channel_serialize✅ (view plot)13,920.00 (-2.05%)14,470.01 (96.20%)✅ (view plot)5,036.00 (-0.53%)5,078.89 (99.16%)✅ (view plot)7,285.00 (-0.44%)7,340.57 (99.24%)✅ (view plot)39.00 (+4.57%)42.05 (92.75%)✅ (view plot)184.00 (-4.00%)199.09 (92.42%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,437.00 (-0.88%)23,025.07 (97.45%)✅ (view plot)7,999.00 (+0.19%)8,006.39 (99.91%)✅ (view plot)11,637.00 (+0.19%)11,644.28 (99.94%)✅ (view plot)81.00 (+10.29%)82.26 (98.46%)✅ (view plot)297.00 (-2.44%)315.08 (94.26%)
client_sv2_setup_connection✅ (view plot)4,573.00 (-2.62%)4,771.41 (95.84%)✅ (view plot)1,474.00 (-1.78%)1,516.89 (97.17%)✅ (view plot)2,238.00 (-1.67%)2,301.53 (97.24%)✅ (view plot)12.00 (+31.44%)13.68 (87.73%)✅ (view plot)65.00 (-4.18%)69.77 (93.17%)
client_sv2_setup_connection_serialize✅ (view plot)15,856.00 (-2.47%)16,512.44 (96.02%)✅ (view plot)5,935.00 (-0.45%)5,977.89 (99.28%)✅ (view plot)8,626.00 (-0.33%)8,678.52 (99.39%)✅ (view plot)46.00 (+3.03%)49.00 (93.88%)✅ (view plot)200.00 (-5.15%)218.06 (91.72%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,296.00 (-0.66%)35,753.62 (98.72%)✅ (view plot)14,827.00 (+0.11%)14,833.65 (99.96%)✅ (view plot)21,776.00 (+0.11%)21,780.88 (99.98%)✅ (view plot)107.00 (+7.26%)113.00 (94.69%)✅ (view plot)371.00 (-2.22%)385.01 (96.36%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🐰Bencher

ReportFri, July 19, 2024 at 11:45:28 UTC
ProjectStratum v2 (SRI)
Branch1026/merge
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handleLatency (nanoseconds (ns))🚨 (view plot | view alert)780.00 (+4.30%)779.13 (100.11%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,723.40 (-3.05%)7,333.48 (91.68%)
client-submit-serialize-deserialize✅ (view plot)7,579.40 (-3.48%)8,322.36 (91.07%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)7,989.30 (-5.06%)8,845.69 (90.32%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)899.35 (+0.09%)926.70 (97.05%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)700.73 (+0.52%)718.04 (97.59%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)246.14 (-0.78%)255.18 (96.46%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.81 (+0.40%)162.48 (97.13%)
client-sv1-get-submit✅ (view plot)6,359.80 (-5.02%)7,136.50 (89.12%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)286.47 (+2.74%)291.77 (98.18%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle🚨 (view plot | view alert)780.00 (+4.30%)779.13 (100.11%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)639.68 (+4.01%)640.00 (99.95%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)203.14 (-1.69%)219.99 (92.34%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

"value": "0x73"
}
],
"actiondoc": "This action checks RequestTransactionData received"
Copy link
Collaborator

@plebhash plebhash Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned above, the mock TP broadcasts NewTemplate and SetNewPrevHash before the JDC has had the time to bootstrap and establish a connection

as a consequence, JDC is never aware of neither of these messages, and it never really sends a RequestTransactionData, so this action keeps hanging and the mock TP doesn't progress

@plebhash plebhash linked an issue Jul 29, 2024 that may be closed by this pull request
@plebhash plebhash changed the base branch from dev to main August 28, 2024 20:17
@rrybarczyk
Copy link
Collaborator

Closing as MG test does not solve for this, we need integration tests for this (#1077).

@rrybarczyk rrybarczyk closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MG test for false fallback activation
3 participants