Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #63 and other minor changes #64

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

thebigbone
Copy link

@thebigbone thebigbone commented Mar 30, 2024

Fix build script, update deployment documentation and correct the wrong subnet in deployment file

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #63

There is an error while running build.sh. Using the correct package manager solves it which is what I did in this PR.

I have also updated deployment.rst file which specifies that the user has to copy the example docker-compose and rename it as docker-compose.yml. After which, the user would be able to run the command to start deployment.

The last change is in the docker-compose.yml file where the subnet is wrong. It should be 172.16.1.0 instead of 172.16.1.1.

What is the new behavior?

  • Build script will successfully create docker images.
  • Correct subnet is assigned.
  • Updated docs.

Adity20 and others added 4 commits March 30, 2024 09:55
```docker-compose.yml``` need to be copied from the example compose file before running ```docker compose up```
@thebigbone thebigbone changed the title fix issue #63 fix issue #63 and other minor changes Mar 30, 2024
@verovaleros
Copy link
Member

There is no description on the PR. If you want the PR to be considered, please follow the guidelines here: https://github.com/stratosphereips/AIVPN/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

@thebigbone
Copy link
Author

Updated the description. Apologies for not including a proper description.

@verovaleros
Copy link
Member

Thanks. Another thing, please review our contributing guidelines, you always need to PR to development, not to main. Please change it and make sure the changes are still valid given there were some changes already that I think may overlap.

@thebigbone
Copy link
Author

I will remove the build script PR as you have already resolved it in the develop branch.

@thebigbone thebigbone changed the base branch from main to develop April 7, 2024 12:12
@thebigbone
Copy link
Author

I have changed the branch. Can you check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants