chore: move to a single-pull-request release process #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release process for this library is currently extremely cumbersome, requiring as many as 13 different release PRs merged in dependency order (with no CI-level enforcement and broken packages very possible) and a very slow build process. Even with relatively minor changes that affect half the packages I've spent an entire day half-distracted by running this process in the background. This PR makes it so that all updated packages will be released at the same time. This is effectively what we do now, and there's very little downside to doing this (except perhaps a bit of extra churn on version numbers on packages that didn't strictly need to be released, but arguably we should be releasing any package number bumps immediately for good repo hygiene). Open to not doing this, but opening to at the very least start the conversation.
alanshaw
dismissed
their stale review
Not sure of consequences for releasing packages in the correct order.
|
ah hm good question - I think it would set all of the version numbers and dependencies to the latest versions, so it shouldn't matter which order they're released in? but I could be missing some order-dependent thing... |
|
…Yes, please? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release process for this library is currently extremely cumbersome, requiring as many as 13 different release PRs merged in dependency order (with no CI-level enforcement and broken packages very possible) and a very slow build process. Even with relatively minor changes that affect half the packages I've spent an entire day half-distracted by running this process in the background.
This PR makes it so that all updated packages will be released at the same time. This is effectively what we do now, and there's very little downside to doing this (except perhaps a bit of extra churn on version numbers on packages that didn't strictly need to be released, but arguably we should be releasing any package number bumps immediately for good repo hygiene).
Open to not doing this, but opening to at the very least start the conversation.