fix: w3filecoin spec separate capabilities to queue and dequeue #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/w3filecoin-spec-separate-capabilities-to-queue-and-enqueue
branch
from
74e65df
to
d493e84
Compare
This was referenced Aug 9, 2023
Closed
|
@Gozala part of me feels that we could do this just for the aggregator actor. However, it also felt weird that same pattern was handled differently and ended up changing the 3 of them. Thoughts? |
alanshaw
reviewed
Aug 21, 2023
| @@ -94,7 +94,7 @@ sequenceDiagram | |||
|
|
|||
| Storefront SHOULD propagate submitted pieces into Filecoin Storage Providers by forwarding them to an aggregator. | |||
|
|
|||
| The Aggregator MUST queue offered pieces for an aggregation and issue a signed receipt proving that submitted piece has been `pending`. Issued receipt MUST link to a followup task (using `.fx.join` field) that either succeeds with inclusion proof (if the piece was included into an aggregate) or fail, in order to allow state lookup by its receipt. | |||
| The Aggregator MUST queue offered pieces for an aggregation and issue a signed receipt proving that submitted piece is `pending` to be added. Issued receipt MUST link to a followup task (using `.fx.join` field) that either succeeds with inclusion proof (if the piece was included into an aggregate) or fail, in order to allow state lookup by its receipt. | |||
There was a problem hiding this comment.
succeeds with inclusion proof
Is this part TBC? I'm not sure I saw where this was defined in this spec.
There was a problem hiding this comment.
we will include it. But still needs to be added to the receipt once we know the format.
alanshaw
approved these changes
Aug 21, 2023
vasco-santos
deleted the
fix/w3filecoin-spec-separate-capabilities-to-queue-and-enqueue
branch
vasco-santos
added a commit
to storacha/w3up
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #71 (comment) , this PR separates capabilities of queue and enqueue into different ones, so that we can have guarantee that storefront requester are who they are by sending their DID in the
withfield, that can then be used in thenbfield for the dequeue.