Skip to content

Commit

Permalink
fix: filecoin spec aggregate accept receipt type (#83)
Browse files Browse the repository at this point in the history
Fixes aggregate/accept receipt:

1. inclusion proof was wrongly here. It should only be in `piece/accept`
because it is piece specific proof within an aggregate
2. added `aggregate` in receipt to be coherent with other receipts for
`*/accept`

Fixes filecoin/accept receipt:
1. added `piece` and `aggregate` in receipt to be coherent with other
receipts for `*/accept`
2. swaped `aux` to be a property per
storacha/w3up#974 (comment)
  • Loading branch information
vasco-santos authored Oct 23, 2023
1 parent cbdb706 commit e469e57
Showing 1 changed file with 15 additions and 20 deletions.
35 changes: 15 additions & 20 deletions w3-filecoin.md
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,11 @@ This task is effectively a shortcut allowing an observer to find out the result
"ran": "bafy...filAccept",
"out": {
"ok": {
/* commitment proof for piece */
"piece": { "/": "commitment...car" },
/* commitment proof for aggregate */
"aggregate": { "/": "commitment...aggregate" },
/** inclusion proof for piece */
"inclusion": {
"tree": {
"path": [
Expand All @@ -279,9 +284,12 @@ This task is effectively a shortcut allowing an observer to find out the result
"at": 7
}
},
"auxDataType": 0,
"auxDataSource": {
"dealID": 1245
/** deal type */
"aux": {
"dataType": 0,
"dataSource": {
"dealID": 1245
}
}
}
}
Expand Down Expand Up @@ -520,23 +528,10 @@ The [Dealer] MUST issue a receipt for the [`aggregate/accept`] task once it arra
"ran": "bafy...aggregateAccept",
"out": {
"ok": {
"inclusion": {
"tree": {
"path": [
"bafk...root",
"bafk...parent",
"bafk...child",
"bag...car"
],
"at": 1
},
"index": {
"path": [/** ... */],
"at": 7
}
},
"auxDataType": 0,
"auxDataSource": {
/* commitment proof for aggregate */
"aggregate": { "/": "bafk...aggregate-proof" },
"dataType": 0,
"dataSource": {
"dealID": 1245
}
}
Expand Down

0 comments on commit e469e57

Please sign in to comment.