Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-11300] Enhance discovery controller to support MultiClusterEngineHCP type discovered clusters #242

Merged
merged 13 commits into from
May 28, 2024

Conversation

dislbenn
Copy link
Contributor

@dislbenn dislbenn commented May 21, 2024

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

https://issues.redhat.com/browse/ACM-11300

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn
Copy link
Contributor Author

/retest

Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn
Copy link
Contributor Author

/retest

Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn
Copy link
Contributor Author

/retest

Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn
Copy link
Contributor Author

/cc @cameronmwall @ngraham20

Signed-off-by: Disaiah Bennett <[email protected]>
Copy link

sonarcloud bot commented May 28, 2024

Copy link
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d68ceec into stolostron:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given dco-signoff: yes lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants