Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-10652] Added previously auto imported annotation to detached discoveredcluster #238

Merged

Conversation

dislbenn
Copy link
Contributor

@dislbenn dislbenn commented Apr 19, 2024

Description

When a DiscoveredCluster is automatically imported, we need to ensure that if the associated ManagedCluster is detached for any reason, we should not re-auto import the DiscoveredCluster back into the hub. To address this scenario, we are adding an annotation when the ManagedCluster is detached to ensure that the cluster is not imported again by default.

Related Issue

https://issues.redhat.com/browse/ACM-10652

Changes Made

Added annotation to prevent re-auto import.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

/cc @cameronmwall @ngraham20

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@openshift-ci openshift-ci bot added dco-signoff: yes approved PR approval has been given labels Apr 19, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

Copy link
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dislbenn
Copy link
Contributor Author

/override "KinD tests (1.21, latest)"

Copy link

openshift-ci bot commented Apr 19, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: KinD tests (1.21, latest)

In response to this:

/override "KinD tests (1.21, latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5955db4 into stolostron:main Apr 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given dco-signoff: yes lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants