Fix e2e fail. #176
Merged
Fix e2e fail. #176
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuezhaojun
force-pushed
the
fix-e2e-fail-1017
branch
from
46d1925
to
c52a44d
Compare
xuezhaojun
force-pushed
the
fix-e2e-fail-1017
branch
2 times, most recently
from
c1c95ce
to
024f7bf
Compare
xuezhaojun
force-pushed
the
fix-e2e-fail-1017
branch
from
024f7bf
to
e645cab
Compare
Signed-off-by: xuezhaojun <[email protected]>
xuezhaojun
force-pushed
the
fix-e2e-fail-1017
branch
from
e645cab
to
c1467fa
Compare
|
/assign @haoqing0110 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upstream upgrade PR, open-cluster-management-io/cluster-proxy#207, it upgrade to using latest image in clusteradm as well.
But in downstream, we don' have this field updated.
@qiujian16 From the question in channel: https://kubernetes.slack.com/archives/C01GE7YSUUF/p1729251075877059. cluster-proxy-addon is not widely used in the community.
So I want to propose to archive cluster-proxy in ocm-io step by step, and then merge cluster-proxy-addon and cluster-proxy repo in stolostron. This way, we can save our energy on diff management and e2e fails on this component.
--
Kudo to @haoqing0110 , help quickly debug the e2e failure.