Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.3 #299

Merged
merged 5 commits into from
Sep 4, 2024
Merged

v1.4.3 #299

merged 5 commits into from
Sep 4, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Sep 4, 2024

Description

2024-09-04

Package

  • Using different github actions for renaming and releasing binaries (thanks @auzaheta)
  • Updated manynet dependence to >=1.0.5

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

Copy link
Contributor

@auzaheta auzaheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is something you might want to consider.
An additional R version that can be used is the devel one. It caches some of the new notes that CRAN was asking for goldfish.

Extracted from the R-check workflow in goldfish

 - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}

In the r-lib/action/setup-r@v2 step:

 - uses: r-lib/actions/setup-r@v2
        with:
          r-version: ${{ matrix.config.r }}
          http-user-agent: ${{ matrix.config.http-user-agent }}
          use-public-rspm: true

The issue with this change is that you want to build the binaries in the same job, in that case an if statement will skip building and uploading for the devel version.

@jhollway
Copy link
Collaborator Author

jhollway commented Sep 4, 2024

Should this be in prchecks.yml instead of pushrelease.yml? But I like the idea; go ahead and place it wherever it should go.

Copy link
Contributor

@auzaheta auzaheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as expected

@jhollway jhollway merged commit 10e0b02 into main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants