Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.1 #296

Merged
merged 7 commits into from
Jul 19, 2024
Merged

v1.4.1 #296

merged 7 commits into from
Jul 19, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Jul 19, 2024

Description

2024-07-19

Package

  • Made package title Title Case in DESCRIPTION
  • Added alttext to icons used in pkgdown site
  • Added CRAN link in pkgdown site
  • Removed unnecessary reexports
  • Dropped 6 Suggests dependencies
  • Dropped 4 Imports dependencies (including {tidyr}, see below)

Models

  • network_reg() renamed to net_regression() for consistency
  • Refactored several functions to avoid {tidyr} dependency for pivoting longer and wider

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

@jhollway jhollway merged commit 88dfd15 into main Jul 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant