Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added core and hierarchy topics to pkgdown file #279

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Added core and hierarchy topics to pkgdown file #279

merged 5 commits into from
Nov 1, 2023

Conversation

jaeltan
Copy link
Collaborator

@jaeltan jaeltan commented Oct 25, 2023

Description

Updates to pkgdown file for additions of core and hierarchy functions to function reference list. For more information on this release, please see #278 .

Marks

  • print.node_mark() and print.tie_mark() now allow infinite 'n' width

Measures

  • print.node_measure() and print.tie_measure() now allow infinite 'n' width
    • Digit rounding is now fixed in print and summary methods

Members

  • print.node_member() now prints the vector
    • Previous functionality is now available in summary.node_member()

jhollway
jhollway previously approved these changes Oct 26, 2023
Copy link
Collaborator

@jhollway jhollway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jaeltan , thanks. Just wonder whether we should accumulate a few more changes, even if just little documentation improvements?

Copy link
Collaborator

@henriquesposito henriquesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for fixing the pkgdown issue @jaeltan !

@jhollway jhollway dismissed stale reviews from henriquesposito and themself via 4046466 October 31, 2023 14:11
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #279 (e97e362) into main (9708d02) will decrease coverage by 2.15%.
Report is 22 commits behind head on main.
The diff coverage is 3.38%.

❗ Current head e97e362 differs from pull request most recent head e255ca7. Consider uploading reports for the commit e255ca7 to get more accurate results

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   53.36%   51.21%   -2.15%     
==========================================
  Files          27       28       +1     
  Lines        2082     2173      +91     
==========================================
+ Hits         1111     1113       +2     
- Misses        971     1060      +89     
Files Coverage Δ
R/member_components.R 0.00% <ø> (ø)
R/class_marks.R 33.33% <0.00%> (-4.17%) ⬇️
R/member_core.R 69.56% <40.00%> (-17.94%) ⬇️
R/class_members.R 3.41% <0.00%> (-0.26%) ⬇️
R/class_measures.R 29.29% <0.00%> (-1.56%) ⬇️
R/measure_hierarchy.R 0.00% <0.00%> (ø)
R/measure_holes.R 72.41% <0.00%> (-18.90%) ⬇️
R/member_community.R 57.37% <0.00%> (-14.06%) ⬇️
R/measure_features.R 56.19% <0.00%> (-14.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhollway jhollway merged commit 96314c5 into main Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants