Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.2 #277

Merged
merged 12 commits into from
Oct 18, 2023
Merged

v1.1.2 #277

merged 12 commits into from
Oct 18, 2023

Conversation

jhollway
Copy link
Collaborator

Description

Package

  • Added more code annotations in 'tutorial4' (Community)
  • Elaborated 'tutorial5' (was named Equivalence, now Position)
  • Chunks in tutorials that are incremental now hidden upon extraction using purl = FALSE argument

Members

  • Improved printing of node_members and node_measures objects

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

@jhollway jhollway requested a review from jaeltan October 18, 2023 11:56
@jhollway jhollway self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #277 (0fcb299) into main (dde0d1d) will decrease coverage by 0.21%.
Report is 10 commits behind head on main.
The diff coverage is 36.73%.

❗ Current head 0fcb299 differs from pull request most recent head c148787. Consider uploading reports for the commit c148787 to get more accurate results

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   53.57%   53.36%   -0.21%     
==========================================
  Files          27       27              
  Lines        2072     2082      +10     
==========================================
+ Hits         1110     1111       +1     
- Misses        962      971       +9     
Files Coverage Δ
R/class_members.R 3.66% <20.00%> (+0.86%) ⬆️
R/class_measures.R 30.85% <51.85%> (+2.56%) ⬆️
R/member_community.R 71.42% <17.64%> (-28.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhollway jhollway merged commit 9708d02 into main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants