Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.5 #96

Merged
merged 3 commits into from
Oct 5, 2024
Merged

v1.2.5 #96

merged 3 commits into from
Oct 5, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Oct 5, 2024

Description

Checklist:

  • PR form
    • Description above itemizes changes under subtitles, e.g. "## Data""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Longer functions are commented inline or broken down into helper functions so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

@jhollway jhollway merged commit e651b76 into main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant