Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using different modes for each phase of an xspi operation #488

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

dne
Copy link
Contributor

@dne dne commented Mar 13, 2024

This adds Config.modes and Xspi.configure_modes methods but keeps the existing API (which sets the same mode for all phases).

@richardeoin
Copy link
Member

Nice that this can be added without breaking backwards compatibility! I think configure_modes should have some documentation ("use this if you want different modes for each phase..") but otherwise looks good.

If you're able to share, it would be great to know if you have tested this on hardware and what the results were.

@dne dne force-pushed the xspi-separate-phase-modes branch from dc63e9f to d71a22d Compare March 20, 2024 22:05
@dne dne force-pushed the xspi-separate-phase-modes branch from d71a22d to e94add8 Compare March 20, 2024 22:12
@dne
Copy link
Contributor Author

dne commented Mar 20, 2024

Nice that this can be added without breaking backwards compatibility! I think configure_modes should have some documentation ("use this if you want different modes for each phase..") but otherwise looks good.

Thanks for reviewing! I've amended the PR to improve the docs, and also attempting to fix the octospi variant that failed in CI.

If you're able to share, it would be great to know if you have tested this on hardware and what the results were.

I've used this successfully with the 'H745 and Infineon S25FL127S QSPI Flash (in quad mode), using the 4QOR and 4QPP commands ("quad output read" and "quad page program" with 4-byte addresses).

Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@richardeoin richardeoin added this pull request to the merge queue Mar 21, 2024
Merged via the queue into stm32-rs:master with commit 2d3653c Mar 21, 2024
22 checks passed
@dne dne deleted the xspi-separate-phase-modes branch March 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants