Reexport Direction from older embedded_hal #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltardieu
force-pushed
the
reexport-direction
branch
from
944d2ef
to
7f5fa10
Compare
|
Note that all the CI failures are unrelated to this patch and also happen on master. |
`embedded_hal::Direction` has been removed from recent `embedded_hal` releases. It needs to be reexported from `qei` in order to allow users of `Qei::direction()` to be able to match against the method result if they use a recent `embdded_hal` release.
samueltardieu
force-pushed
the
reexport-direction
branch
from
7f5fa10
to
89a097b
Compare
|
Rebased on current master (which now compiles). |
burrbull
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embedded_hal::Directionhas been removed from recentembedded_halreleases. It needs to be reexported fromqeiin order to allow users ofQei::direction()to be able to match against the method result if they use a recentembdded_halrelease.