Add is42s32400f to devices #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliDi
reviewed
May 16, 2024
tegimeki
reviewed
Jul 31, 2024
Co-authored-by: Michael Fairman <[email protected]>
|
Thanks! @richardeoin can we get this merged? |
+1 for getting this in - thanks @joelsa and @richardeoin for the work on this crate! I am hoping to reference an updated release when it is available, to enable adding an example in stm32-rs/stm32f4xx-hal#759 (or subsequent branch) for an STM32F469 board which uses this memory. |
|
LGTM, thanks everyone for the review! |
|
And it's available on crates.io as v0.3.1 🎉 |
|
Right - the module isn't imported anywhere |
|
Fixed in #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config for IS42S32400F-6BL SDRAM, which is found on 32F746GDISCOVERY and 32F469IDISCOVERY eval boards.